Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39195
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.235.152.150 cause and error)
Message-ID: <01b401c8ec13$28cd3510$0201a8c0@pc1>
To: <internals@lists.php.net>
Cc: "Lukas Kahwe Smith" <mls@pooteeweet.org>
Date: Tue, 22 Jul 2008 10:52:28 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: [PATCH] New functions: array_replace[_recursive]
From: php_lists@realplain.com ("Matt Wilmas")

Hi all,

Adding these two array functions has been on the TODO for a while, and my
original patch has been collecting dust for almost 2 years. :-)  I just
updated the patches now after some small changes (the original version for
5.2 is currently linked on the wiki).  A brief description, if I remember
correctly, especially the recursive version (Lukas can maybe give more info.
since he created the original implementation in PHP ;-)):

array_replace() is like the + operator applied to arrays, except that it
WILL overwrite ("replace") existing entries.  array_replace_recursive() will
do the same except that it becomes recursive only when both the destination
and source entries are arrays, otherwise the new source entry still replaces
any existing one.

In the wrapper function, I removed the SEPARATE_ZVAL() and
convert_to_array_ex() as they appear to be leftover from PHP 4 (before
array_merge[_recursive] checked if the args were arrays first).  This made a
big performance difference when I benchmarked 2 years ago!  I also updated
it to use array_init_size() (returned array will have at least as many
elements as the largest input array) for another small optimization.

http://realplain.com/php/array_replace.diff
http://realplain.com/php/array_replace_5_3.diff  (With NEWS entry)
http://realplain.com/php/array_replace.phpt  (Still has the old UEXPECT
section for HEAD; will fix if I commit)

Any thoughts or objections?  Should I commit before Thursday, like
tomorrow...?


Thanks,
Matt