Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39113
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fmethod.com from 69.16.228.148 cause and error)
Message-ID: <13F3C3E0FB864C919A2048D507EDB9B9@pc>
To: "internals" <internals@lists.php.net>
References: <d296fda90807190555g63312998rf2192f5cd4e05a88@mail.gmail.com> <1216514217.11114.6.camel@localhost> <488295AC.3000107@lerdorf.com>
Date: Sun, 20 Jul 2008 14:55:01 +0300
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="utf-8";
	reply-type=response
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] New string functions: str_startswith() and	str_endswith()
From: sv_forums@fmethod.com ("Stan Vassilev | FM")


Hi,

Actually starts with and ends with is a very common case. I see your 
concerns, but I can see instantly quite a lot of places in my code where I'd 
use those. And I bet it'll be faster too.

Many of the string functions can be replicated with one-liners using other 
string functions, same for array functions. I still think a very common case 
should be addressed natively.

Regards,
Stan Vassilev

> For the start of the string:
>
>   substr($haystack,0,strlen($needle)) == $needle
>
> And for the end of the string:
>
>   substr($haystack,-strlen($needle)) == $needle
>
> For case-insensitivity, just strtolower both.
>
> Writing built-in functions for something that can be done with trivial 
> one-liners isn't something we typically do.
>
> -Rasmus
>
> Lars Strojny wrote:
>> Hi Martin,
>>
>> first of all, thanks for you work! A few comments below.
>>
>> Am Samstag, den 19.07.2008, 14:55 +0200 schrieb Martin Jansen:
>>> Attached you'll find a patch against PHP_5_3 that implements two new
>>> string functions:
>>>
>>> str_startswith(haystack, needle [, case_sensitivity])
>>
>> That's in my opinion too easy to solve with strpos($haystack, $needle)
>> === 0.
>>
>>> checks if haystack starts with needle. The check is performed
>>> case-insensitively, but this can be overridden by passing TRUE as the
>>> value for the third parameter. The second function
>>>
>>> str_endswith(haystack, needle [, case_sensitivity])
>> [...]
>>
>> Suffix checking is indeed a bit harder. But I'm not sure if we should
>> introduce a function for every special case. Suffix verification often
>> is about verifying file extensions. That could be easily solved with
>> pathinfo() (and to make that easier, it would be more helpful to allow
>> the engine to directly access returned arrays like
>> pathinfo($file)['extension']). The other thing I would love to see is
>> something I really love in Ruby: you have various ways to work with
>> substrings[1]. For example you can do "foobar"[-3,3] == "bar" to check
>> the suffix. That's in my opinion much easier and flexible.
>>
>> So -1 from me for the new string functions, but +1 for niftier variants
>> to work with offsets.
>>
>> [1] ﻿http://pleac.sourceforge.net/pleac_ruby/strings.html
>>
>> cu, Lars
>
>
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>