Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39102 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89970 invoked from network); 19 Jul 2008 15:58:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jul 2008 15:58:16 -0000 Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender) X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6 Received: from [85.214.94.56] ([85.214.94.56:50775] helo=h1149922.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 31/81-13864-71F02884 for ; Sat, 19 Jul 2008 11:58:15 -0400 Received: from MBOERGER-ZRH.corp.google.com (unknown [193.142.125.1]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by h1149922.serverkompetenz.net (Postfix) with ESMTP id 7F83D11EFE8; Sat, 19 Jul 2008 17:58:12 +0200 (CEST) Date: Sat, 19 Jul 2008 17:57:40 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1657130941.20080719175740@marcus-boerger.de> To: "Arnaud Le Blanc" CC: Marcus Boerger , "internals" In-Reply-To: <200807101416.33835.arnaud.lb@gmail.com> References: <200807081549.36758.arnaud.lb@gmail.com> <200807091616.20332.arnaud.lb@gmail.com> <152910573.20080709200614@marcus-boerger.de> <200807101416.33835.arnaud.lb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation From: helly@php.net (Marcus Boerger) Hello Arnaud, Thursday, July 10, 2008, 2:16:33 PM, you wrote: > Hello, > On Wednesday 09 July 2008 20:06:14 Marcus Boerger wrote: >> Hello Arnaud, >> >> if you can provicde the same for HEAD then I'll submit it. And if you're >> fast enough we might even get it into 5.3.0 :-) Johannes, Lukas, how >> much time does he have? >> >> marcus > Ok, I made it [1]. I never walked through the PHP6 code until now, I hope this > is correct. > getPrefix and getPostfix return a binary or unicode string depending on > UG(unicode). > getEntry returns the original value if it is binary or unicode. Else it > converts it depending on UG(unicode), as the purpose of this method is to > cast to string. > The convertion from array to string in getPrefix throws E_NOTICE errors, so I > had to change the error_reporting setting in my test cases [2] for them to > pass. I don't know if I may remove these errors or not. > current returns the type returned by getEntry. > key acts like getEntry. > I added a test (005) for the returned types. And an other (006) to test the > case where RecursiveTreeIterator got an IteratorAggregate as first param. All > tests should pass on 5.3 except 005. > [1] http://arnaud.lb.s3.amazonaws.com/RecursiveTreeIterator_HEAD.patch > [2] http://arnaud.lb.s3.amazonaws.com/RecursiveTreeIterator-phpt.tar.bz2 > Arnaud Slightly modified and applied. Thanks for the good work. Care to look into the MultipleIterator next? marcus Best regards, Marcus