Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39090
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 193.227.246.108 as permitted sender)
Message-ID: <488095DB.5020107@php.net>
Date: Fri, 18 Jul 2008 14:08:43 +0100
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: Steph Fox <steph@php.net>
CC: Pierre Joye <pierre.php@gmail.com>, 
 internals <internals@lists.php.net>
References: <043f01c8e87f$63257930$a7bd614d@foxbox> <fe05d1540807180021p7cdb5f56k14e09aa842c00a7a@mail.gmail.com> <001701c8e8c1$e01a6ee0$a7bd614d@foxbox> <488079A5.3020401@php.net> <008f01c8e8c8$691b9e20$a7bd614d@foxbox> <48807FC7.2060302@php.net> <00cb01c8e8cd$1b5871e0$a7bd614d@foxbox>
In-Reply-To: <00cb01c8e8cd$1b5871e0$a7bd614d@foxbox>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam_Report: Spam detection software, running on the system "lovelace.midden.org.uk", has
	identified this incoming email as possible spam.  The original message
	has been attached to this so you can view it (if it isn't spam) or label
	similar future email.  If you have any questions, see
	the administrator of that system for details.
	Content preview:  I've committed a fix now and it compiles correctly, I also
	removed the two warnings. Scott Steph Fox wrote: > > Scott, > >>> Isn't it
	just a case of rewriting php_apache_fteller_stream() to use >>> the new API?
	>> >> I think we can actually just add an fsizer function and use >> apr_brigade_length(pbb->bb);
	> > I think that's what 'rewriting php_apache_fteller_stream() means ;) Why
	> move it from pbb->total_len? > >> That should give us the length of all
	the data in the bucket brigade, >> not tested as I'm not even sure about
	how to go about doing so. I'll >> commit a patch later today to 5.3 and then
	merge all these missed >> changes to HEAD. > > Cool, > > - Steph > [...] 
	Content analysis details:   (-4.4 points, 5.0 required)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.8 ALL_TRUSTED            Passed through trusted hosts only via SMTP
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
	0.0 AWL                    AWL: From: address is in the auto white-list
Subject: Re: [PHP-DEV] Apache builds
From: scottmac@php.net (Scott MacVicar)

I've committed a fix now and it compiles correctly, I also removed the 
two warnings.

Scott

Steph Fox wrote:
> 
> Scott,
> 
>>> Isn't it just a case of rewriting php_apache_fteller_stream() to use 
>>> the new API?
>>
>> I think we can actually just add an fsizer function and use 
>> apr_brigade_length(pbb->bb);
> 
> I think that's what 'rewriting php_apache_fteller_stream() means ;) Why 
> move it from pbb->total_len?
> 
>> That should give us the length of all the data in the bucket brigade, 
>> not tested as I'm not even sure about how to go about doing so. I'll 
>> commit a patch later today to 5.3 and then merge all these missed 
>> changes to HEAD.
> 
> Cool,
> 
> - Steph
>