Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39084
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 193.227.246.108 as permitted sender)
Message-ID: <488079A5.3020401@php.net>
Date: Fri, 18 Jul 2008 12:08:21 +0100
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: Steph Fox <steph@php.net>
CC: Pierre Joye <pierre.php@gmail.com>, 
 internals <internals@lists.php.net>
References: <043f01c8e87f$63257930$a7bd614d@foxbox> <fe05d1540807180021p7cdb5f56k14e09aa842c00a7a@mail.gmail.com> <001701c8e8c1$e01a6ee0$a7bd614d@foxbox>
In-Reply-To: <001701c8e8c1$e01a6ee0$a7bd614d@foxbox>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam_Report: Spam detection software, running on the system "lovelace.midden.org.uk", has
	identified this incoming email as possible spam.  The original message
	has been attached to this so you can view it (if it isn't spam) or label
	similar future email.  If you have any questions, see
	the administrator of that system for details.
	Content preview:  Hey Steph, John worked on apache2filter and for some reason
	he only made a change to do with streams on the 5.x branch [1] and never
	merged his change to head. It means that currently apache2filter works on
	HEAD but not on PHP 5.3 [...] 
	Content analysis details:   (-4.4 points, 5.0 required)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.8 ALL_TRUSTED            Passed through trusted hosts only via SMTP
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
	0.0 AWL                    AWL: From: address is in the auto white-list
Subject: Re: [PHP-DEV] Apache builds
From: scottmac@php.net (Scott MacVicar)

Hey Steph,

John worked on apache2filter and for some reason he only made a change 
to do with streams on the 5.x branch [1] and never merged his change to 
head. It means that currently apache2filter works on HEAD but not on PHP 5.3

I've not yet had time to see if there is a way to get a length of 
content from a previous brigade in Apache. We may just need to buffer 
the result and then call it? I'm unsure at the moment.

Also I dont think the apache filter SAPI is in use by anyone, but I 
could be wrong here.

Scott

[1] - 
http://cvs.php.net/viewvc.cgi/php-src/sapi/apache2filter/sapi_apache2.c?view=log#rev1.136.2.2.2.1


Steph Fox wrote:
> 
> Pierre,
> 
>> It is not due to re2c introduction but to changes committed only in
>> one branch and never merged to HEAD. Then good developers worked in
>> HEAD and merged to 5.3 ending with the current mess.
> 
> Y'know, attacking me every time I make a move is counterproductive. In 
> this case, it means that anybody who has a clue about fixing the problem 
> won't bother reading my initial post.
> 
> http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_ini_scanner.h?view=log 
> tells me that a) the commit was made in 5_3 and merged to HEAD ten days 
> later (and nobody screamed), b) that the changes are part of that patch 
> and c) that the same problem exists in both branches.
> 
> I would have spent today on HEAD, but unfortunately I have work 
> outstanding in 5_3 branch because of all this silliness. It's likely to 
> be Sunday before I can get to it now.
> 
> Anyone who actually knows how to fix the apache2filter sapi to use the 
> new zend_stream struct introduced as part of the re2c changes is welcome 
> to comment, assuming they got as far as this.
> 
> - Steph
>