Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39002 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99314 invoked from network); 16 Jul 2008 10:41:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Jul 2008 10:41:00 -0000 Authentication-Results: pb1.pair.com header.from=arvids.godjuks@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=arvids.godjuks@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.204.228 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: arvids.godjuks@gmail.com X-Host-Fingerprint: 72.14.204.228 qb-out-0506.google.com Received: from [72.14.204.228] ([72.14.204.228:21067] helo=qb-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1B/47-54589-B30DD784 for ; Wed, 16 Jul 2008 06:41:00 -0400 Received: by qb-out-0506.google.com with SMTP id p30so6319084qba.15 for ; Wed, 16 Jul 2008 03:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=FS0adhBv77i0ozsHab8Uyi1kqZm3/MgD/GwjLCOffgE=; b=nqgKVUyTX/B55jh+3tsKamLVWN0prfY4TzB6AAIqUAITJ8NJqcHZRYg0utDJ5dnLYs b8tTv70BGtBKOIyWS5drifqrFbK1MKpwBxEfCTRplzHVirqNo0dUKN25nI2hVL6S0uzy wehWApEx9UmvckYbK42/V0r1mklcE0Tmlb5R8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=qTpWtNzcYMZWSQ+KGiXICZoFOHFT1yFUXQNCB2KDQuBj+22RTV1p03S4KDHerCdlgz vXssbuNcrItDjRfHtiw80IDCRZCcllF/AA0bwRgLwK6DMmUTGhsEgXwM4zOD2EEWFDTI 9AXJYc5Z0EvREhQjYjSYuTf5rwDrLC8NBzzJ0= Received: by 10.67.92.10 with SMTP id u10mr3129621ugl.6.1216204858273; Wed, 16 Jul 2008 03:40:58 -0700 (PDT) Received: by 10.67.96.8 with HTTP; Wed, 16 Jul 2008 03:40:58 -0700 (PDT) Message-ID: <9b3df6a50807160340w578d7490xb6f2810652e1bb47@mail.gmail.com> Date: Wed, 16 Jul 2008 13:40:58 +0300 To: "Oleg Grenrus" Cc: "Rasmus Lerdorf" , "PHP Internals List" In-Reply-To: <5a2b1bf10807152247r563092a6l88d555d2389506e4@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_31700_23745778.1216204858287" References: <1216133436.6875.35.camel@amirh> <487CEF26.7030802@lerdorf.com> <1216159988.28846.12.camel@localhost> <487D22AE.20109@lerdorf.com> <5a2b1bf10807152247r563092a6l88d555d2389506e4@mail.gmail.com> Subject: Re: [PHP-DEV] lstat call on each directory level From: arvids.godjuks@gmail.com ("Arvids Godjuks") ------=_Part_31700_23745778.1216204858287 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello. I think this should be optimized. I'm not an expert ofcourse, but as I understood there is only one case witch need a special treatment - require/include _one when a file with equal contents is included from different directories. You can make a switch witch controls if lstat is made or not in these cases. People who know what they are doing will switch it to off and make sure their includes don't result in Fatal error (anyway, to my opinion it is bad desing if such thing happens). Ofcourse open_basedir users will don't have any benefit from it, but that's their choise. So I think you should think it out and make this optimization to 5.3 release. It would be great optimization, IMHO. ------=_Part_31700_23745778.1216204858287--