Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38897
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.185 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id;
        b=LmEWK1SiGGMA+fI/bQVw1zXjLN9XSiAk7ZhOVzSCJ7iimQVtec1F1prfoIGlsUADBu
         D4xxEvZsE1M/lX9pZSDmvGnquzio5v7nfv7Z/o8xnyyPuufur/T6iapOjMyGQto7Az8g
         BE4LjTyujcvmnhRJXzoQt9E7EL3El3Y87tIWQ=
To: Marcus Boerger <helly@php.net>
Date: Thu, 10 Jul 2008 14:16:33 +0200
User-Agent: KMail/1.9.9
Cc: "internals" <internals@lists.php.net>
References: <200807081549.36758.arnaud.lb@gmail.com> <200807091616.20332.arnaud.lb@gmail.com> <152910573.20080709200614@marcus-boerger.de>
In-Reply-To: <152910573.20080709200614@marcus-boerger.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200807101416.33835.arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation
From: arnaud.lb@gmail.com ("Arnaud Le Blanc")

Hello,

On Wednesday 09 July 2008 20:06:14 Marcus Boerger wrote:
> Hello Arnaud,
> 
>   if you can provicde the same for HEAD then I'll submit it. And if you're
>   fast enough we might even get it into 5.3.0 :-) Johannes, Lukas, how
>   much time does he have?
> 
>   marcus

Ok, I made it [1]. I never walked through the PHP6 code until now, I hope this 
is correct.

getPrefix and getPostfix return a binary or unicode string depending on 
UG(unicode).

getEntry returns the original value if it is binary or unicode. Else it 
converts it depending on UG(unicode), as the purpose of this method is to 
cast to string.

The convertion from array to string in getPrefix throws E_NOTICE errors, so I 
had to change the error_reporting setting in my test cases [2] for them to 
pass. I don't know if I may remove these errors or not.

current returns the type returned by getEntry.

key acts like getEntry.

I added a test (005) for the returned types. And an other (006) to test the 
case where RecursiveTreeIterator got an IteratorAggregate as first param. All 
tests should pass on 5.3 except 005.

[1] http://arnaud.lb.s3.amazonaws.com/RecursiveTreeIterator_HEAD.patch
[2] http://arnaud.lb.s3.amazonaws.com/RecursiveTreeIterator-phpt.tar.bz2

Arnaud