Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:38871 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59176 invoked from network); 9 Jul 2008 09:18:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Jul 2008 09:18:56 -0000 Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender) X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6 Received: from [85.214.94.56] ([85.214.94.56:42905] helo=h1149922.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 25/00-58665-E7284784 for ; Wed, 09 Jul 2008 05:18:55 -0400 Received: from MBOERGER-ZRH.corp.google.com (100-156.107-92.cust.bluewin.ch [92.107.156.100]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by h1149922.serverkompetenz.net (Postfix) with ESMTP id 134B511F57E; Wed, 9 Jul 2008 11:18:51 +0200 (CEST) Date: Wed, 9 Jul 2008 11:18:22 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <509955367.20080709111822@marcus-boerger.de> To: "Arnaud Le Blanc" CC: "internals" In-Reply-To: <200807081549.36758.arnaud.lb@gmail.com> References: <200807081549.36758.arnaud.lb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation From: helly@php.net (Marcus Boerger) Hello Arnaud, Tuesday, July 8, 2008, 3:49:36 PM, you wrote: > Hi, > I have seen a "NEEDS DEVELOPER" flag on the TODO for the "Implement > RecursiveTreeIterator in C" task, so I would like to propose my > implementation [1]. > Currently it follows the PHP implementation, except that it does not have a > $prefix public property (how about a private property and a setter method ?). > I hope this patch will be useful. Please say me if anything is wrong with it. > [1] http://arnaud.lb.s3.amazonaws.com/RecursiveTreeIterator.patch > [2] http://arnaud.lb.s3.amazonaws.com/RecursiveTreeIterator-phpt.tar.bz2 > Regards, Looks very good! Many thanks. Best regards, Marcus