Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38769
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.44.28 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references:x-google-sender-auth;
        b=CEYk+XFeOqh+CQVd8sESv42DPOyVfzvVEWR+pEmuWNDmCOTqT23j+pi5ccC+gi5oCj
         dnNeiYKFHxOZUC5P2Te02i6fU6t5UXfkL1moRWkT1o46qzsNTfQPjF4XOyWc5CK5OoGt
         1kbATCAhjqCEXU4xmwIDPvR44qedXDG8+OPGQ=
Message-ID: <e666c3890807040703h65bd10c1l90a9dbea93a5e53@mail.gmail.com>
Date: Fri, 4 Jul 2008 16:03:10 +0200
Sender: ekneuss@gmail.com
To: "Lars Strojny" <lars@strojny.net>
Cc: "=?ISO-8859-1?Q?Johannes_Schl=FCter?=" <johannes@php.net>, 
	"Derick Rethans" <derick@php.net>, 
	"php-dev List" <internals@lists.php.net>
In-Reply-To: <1215178480.8875.36.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1215076043.7021.10.camel@localhost>
	 <alpine.DEB.0.98.0807041013280.6963@kossu.ez.no>
	 <1215160135.8875.14.camel@localhost>
	 <1215162928.32294.5.camel@goldfinger.johannes.nop>
	 <1215163596.8875.22.camel@localhost>
	 <1215172604.32294.34.camel@goldfinger.johannes.nop>
	 <1215174704.8875.32.camel@localhost>
	 <e666c3890807040550g23baac49h67c888775b3e311@mail.gmail.com>
	 <1215178480.8875.36.camel@localhost>
Subject: Re: [PHP-DEV] [RFC] Namespaces for internal classes
From: colder@php.net ("Etienne Kneuss")

Hi,

but there is already a structure in the namings of classes, and it's
already documented:
" Iterators and Exceptions are however simply postfixed with
"Iterator" and "Exception." Examples: "

IMO this rule should still be valid in namespaces so I'd group
iterators along with what they iterates on, rather than grouping them
together. This will be especially useful when classes like Graph will
appear, as they will have multiple different iterators/visitors.

If we have to rename what we import in order to make the code clear
(i.e your example about LogicException), it looks like a sign that the
namespace should be named/grouped differently.

Besides, I don't believe "List" is a correct term to group
queue/stack/heap/.... Spl::Datastructure sounds more correct.

Regards,

On Fri, Jul 4, 2008 at 3:34 PM, Lars Strojny <lars@strojny.net> wrote:
> Hi Etienne,
>
> Am Freitag, den 04.07.2008, 14:50 +0200 schrieb Etienne Kneuss:
> [...]
>> a big -1 from me on the namings
>> I really see no point in having:
>>
>> use Spl::Exception;
>> throw new Logic;
>
> use Spl::Exception::Logic as LogicException;
> throw new LogicException();
>
> Besides that, what we should keep in mind, whatever structure we define
> it is likely that this structure sends an important signal towards other
> projects (frameworks, libraries) and how they use namespaces. My
> objection with your proposed method is, that while it fixes the problem
> of clashes, it fails to structure the classes in the package "Spl".
>
> cu, Lars
>



-- 
Etienne Kneuss
http://www.colder.ch

Men never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal