Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38703
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <486BBB1D.8050300@zend.com>
Date: Wed, 02 Jul 2008 10:30:05 -0700
Organization: Zend Technologies
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: Christian Seiler <chris_se@gmx.net>
CC: php-dev List <internals@lists.php.net>
References: <486B6960.4030705@gmx.net>
In-Reply-To: <486B6960.4030705@gmx.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Closures: updated proposal and patch
From: stas@zend.com (Stanislav Malyshev)

Hi!

Re-reading the proposal, I encountered something unexpected:

$replacer = $example->getReplacer ('goodbye');
echo $replacer ('hello world'); // goodbye world
$replacer->setSearch ('world');
echo $replacer ('hello world'); // hello goodbye

Does it mean closure would forward all method calls to it to the 
enclosed object? Not sure if it's a good idea - seems too magical. Maybe 
we need to be more explicit, something like 
$replacer->getThis()->setSearch('world')? I.e., if you have object of 
type Closure, you can't actually know what methods it has - it'd depend 
on $this inside, which we don't have access to right now. That seems 
kind of strange.
Or did you just mean $example->setSearch() and I'm worried about 
nothing? :) In this case, I'd just propose to have getThis() anyway.

Except for that - excellent work!
-- 
Stanislav Malyshev, Zend Software Architect
stas@zend.com   http://www.zend.com/
(408)253-8829   MSN: stas@zend.com