Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:38698 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88028 invoked from network); 2 Jul 2008 06:53:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Jul 2008 06:53:00 -0000 Authentication-Results: pb1.pair.com header.from=indeyets@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=indeyets@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.46.28 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: indeyets@gmail.com X-Host-Fingerprint: 74.125.46.28 yw-out-2324.google.com Received: from [74.125.46.28] ([74.125.46.28:19052] helo=yw-out-2324.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EA/4C-10269-BC52B684 for ; Wed, 02 Jul 2008 02:52:59 -0400 Received: by yw-out-2324.google.com with SMTP id 5so115440ywb.83 for ; Tue, 01 Jul 2008 23:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=htu0An1l8565LtIpYkQhRR2hlX/i9pr0HrzGASbH3wI=; b=o+hs5QZNW2RMzwBXbLDYXBhEY02To5zMYKJvd/8SCE8wuHBdwxU2hvNBe7oFZ0PlaS i0IccS4PhfJk0oj6zyveAiYHDci57WhmADwRpyPrp9wZ+EERBPnQqnuH92ET6sWkue5V iJ3n6GLwf4yEB99OkA3uITuJgLTB0CdA/sjf8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=ZZuS/zQuQGWVUO79wd1BbPjmC1IHKlfJCXT+YNFSzSYiZMWCJE0xz4Rcqj4J8Xa3OF nwGLoS853uqiHYAzc/+E5zDvNixBQOlS2RdiNt9/eSNqS3BvT+3Cw/ETcifL1PCbAlit AeokAYmU+RD8uC8BblPlNSjDWKCCb56RDFK0s= Received: by 10.150.49.2 with SMTP id w2mr12225485ybw.27.1214981577060; Tue, 01 Jul 2008 23:52:57 -0700 (PDT) Received: by 10.150.158.8 with HTTP; Tue, 1 Jul 2008 23:52:57 -0700 (PDT) Message-ID: Date: Wed, 2 Jul 2008 10:52:57 +0400 To: "Antony Dovgal" Cc: internals@lists.php.net In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <486894FF.4000305@daylessday.org> <48689908.2040007@daylessday.org> Subject: Re: [PHP-DEV] mac os x, test failure From: indeyets@gmail.com ("Alexey Zakhlestin") On Wed, Jul 2, 2008 at 10:19 AM, Alexey Zakhlestin wrote: > some more details. > the return-chain in this case is following: > > virtual_file_ex(..., path, ...) -> returns 1, because path_length >= MAXPATHLEN > expand_filepath(filepath, ...) -> returns null > _php_stream_fopen(filename, ...) -> returns null > php_plain_files_stream_opener(..., path, ...) -> returns null > _php_stream_open_wrapper_ex(path, ...) calls php_stream_display_wrapper_errors() > php_stream_display_wrapper_errors() checks errno-value > > I don't see how any function here might set errno to any value. How > does this work on other operating-systems? Anyway, I am leading to this: it is wrong, to check errno-value anywhere, except right after the call, which sets errno The proper solution would be, to have a pointer to some structure passed to the callchain above, and explicitly store error-code/string in virtual_file_ex() -- Alexey Zakhlestin http://blog.milkfarmsoft.com/