Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38673
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.230 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references:x-google-sender-auth;
        b=BXV9vVYQNLXsKQbS2S9+q9uPw+vL16FjPZibwt7Q8F3DJ8OjSaDpP//0RI46AdMkHZ
         nOLnfwY9AXO32w7mhswYYJQiJd+mGw6KlrNcTmDg93c1syCOMeOhCn0Ru7TZw9TQPnf5
         5bBre5yiWSOATCNj6V+bmCnjJmTbAGLt1lEQ0=
Message-ID: <b5f7bf6c0806281220s3de67883q50a50195bb851f11@mail.gmail.com>
Date: Sat, 28 Jun 2008 20:20:28 +0100
Sender: david.coallier@gmail.com
To: "Jordan Wambaugh" <jordan@wambaugh.org>
Cc: "PHP Internals" <internals@lists.php.net>
In-Reply-To: <7439A4DE-6DBA-405E-9210-C3819AD1E59B@wambaugh.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <485AE658.3050204@zend.com>
	 <043C48F1-00DF-4882-AB70-A368C5D32DA1@wambaugh.org>
	 <b5f7bf6c0806280427p4b56513p3de65e935648c631@mail.gmail.com>
	 <7439A4DE-6DBA-405E-9210-C3819AD1E59B@wambaugh.org>
Subject: Re: [PHP-DEV] cleaning up the functions - any volunteers?
From: davidc@php.ie ("David Coallier")

2008/6/28 Jordan Wambaugh <jordan@wambaugh.org>:
>
> On Jun 28, 2008, at 7:27 AM, David Coallier wrote:
>
>> The idea of the new parsing parameter is to catch the number of
>> parameters as well. For instance when you have
>>
>>      if (ZEND_NUM_ARGS() < 2) {
>>              WRONG_PARAM_COUNT;
>>      }
>>
>> then your zend parse param function call should have 2 params or more
>> Ex:
>>
>>   int argc;
>>   char *name;
>>   zval **other;
>>
>>   if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sZ", &name,
>> &other, &argc) == FAILURE) {
>>       return;
>>   }
>>
>> This way of parsing the parameters remove the ZEND_NUM_ARGS() and
>> WRONG_PARAM_COUNT and adds consistency in the return error messages
>> across the language.
>>
>> Also next time please read the previous entries of the thread :
>>
>> See: http://url.ie/hck  that was about the 3rd or 4th message.
>>
>> Anyways that's ok, I lot of conflicts now in formatted_print.c and
>> assert.c but I'll work around them to get the resolved. We just have
>> to get organized on which files we'll be working on then. Right now,
>> Olivier is working on file.c and has done string.c so please don't do
>> those 2 files.
>
> Ok, sorry, I didn't catch the thread where you said you were going to work
> on standard. Do you want me to fix it so I'm not checking ZEND_NUM_ARGS, or
> should I just leave that to you?

Go ahead, you are pretty well started, I'll adjust after you are done :)


-- 
Slan,
David