Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38668
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain wambaugh.org from 74.125.46.30 cause and error)
Message-ID: <7439A4DE-6DBA-405E-9210-C3819AD1E59B@wambaugh.org>
To: PHP Internals <internals@lists.php.net>
In-Reply-To: <b5f7bf6c0806280427p4b56513p3de65e935648c631@mail.gmail.com>
Content-Type: multipart/alternative; boundary=Apple-Mail-6-134560255
Mime-Version: 1.0 (Apple Message framework v924)
Date: Sat, 28 Jun 2008 10:56:01 -0400
References: <485AE658.3050204@zend.com> <043C48F1-00DF-4882-AB70-A368C5D32DA1@wambaugh.org> <b5f7bf6c0806280427p4b56513p3de65e935648c631@mail.gmail.com>
Subject: Re: [PHP-DEV] cleaning up the functions - any volunteers?
From: jordan@wambaugh.org (Jordan Wambaugh)

--Apple-Mail-6-134560255
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit


On Jun 28, 2008, at 7:27 AM, David Coallier wrote:

> The idea of the new parsing parameter is to catch the number of
> parameters as well. For instance when you have
>
>       if (ZEND_NUM_ARGS() < 2) {
>               WRONG_PARAM_COUNT;
>       }
>
> then your zend parse param function call should have 2 params or more
> Ex:
>
>    int argc;
>    char *name;
>    zval **other;
>
>    if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sZ", &name,
> &other, &argc) == FAILURE) {
>        return;
>    }
>
> This way of parsing the parameters remove the ZEND_NUM_ARGS() and
> WRONG_PARAM_COUNT and adds consistency in the return error messages
> across the language.
>
> Also next time please read the previous entries of the thread :
>
> See: http://url.ie/hck  that was about the 3rd or 4th message.
>
> Anyways that's ok, I lot of conflicts now in formatted_print.c and
> assert.c but I'll work around them to get the resolved. We just have
> to get organized on which files we'll be working on then. Right now,
> Olivier is working on file.c and has done string.c so please don't do
> those 2 files.

Ok, sorry, I didn't catch the thread where you said you were going to  
work on standard. Do you want me to fix it so I'm not checking  
ZEND_NUM_ARGS, or should I just leave that to you?
I noticed mysql needs some love... anyone working on mysql, or can I  
take it?

--
Jordan CM Wambaugh
jordan@wambaugh.org



--Apple-Mail-6-134560255--