Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38648
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.net designates 213.165.64.20 as permitted sender)
To: internals@lists.php.net
Date: Thu, 26 Jun 2008 22:46:23 +0200
User-Agent: KMail/1.9.9
Cc: Christian Seiler <chris_se@gmx.net>,
 Dmitry Stogov <dmitry@zend.com>,
 Andi Gutmans <andi@zend.com>,
 Stanislav Malyshev <stas@zend.com>
References: <4856A547.3080801@gmx.net> <485B908D.7000106@zend.com> <4863C299.1080002@gmx.net>
In-Reply-To: <4863C299.1080002@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200806262246.24193.waqner@gmx.net>
Subject: Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP
From: waqner@gmx.net (Alexander Wagner)

>   * I added tests (Zend/tests/closures_*.phpt) that ensure the correct
>     behaviour of closures.

I'd like to propose an additional test to ensure closures can all themselves:
<?php
$i = 3;

$lambda = function ($lambda) use ($i) {
    if ($i==0) return;
    echo $i--."\n";
    $lambda($lambda);
};

$lambda($lambda);
echo "$i\n";
?>
Expected output:
3
2
1
3

I see exactly one problem with the patch, which is that the above script 
shouldn't work without "use (&$i)".
I find it counterintuitive that the creation of the lambda creates a copy of 
$i, but all invocations of $lambda use a reference to the same $i.
For n calls to $lambda, there are only 2 copies of $i (one global, one static 
in $lambda) where I would expect n+1 copies.

Gesundheit
  Wag

-- 
Sieh dich, nimm Sorge.