Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:38548 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59003 invoked from network); 23 Jun 2008 17:13:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jun 2008 17:13:04 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.92.173 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 66.249.92.173 ug-out-1314.google.com Received: from [66.249.92.173] ([66.249.92.173:24225] helo=ug-out-1314.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3A/1C-03212-E99DF584 for ; Mon, 23 Jun 2008 13:13:03 -0400 Received: by ug-out-1314.google.com with SMTP id h3so451082ugf.29 for ; Mon, 23 Jun 2008 10:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=7lQKwfaJC2IW6Vn5T/CfYCyn85cbx4FXS0jeyS8mfZA=; b=bAyiF3eoPaja/1rPDB7KnTrAwq/8h6I1LHhzPuJmGWp+Fj+5vdSxwEEAtItZAihEIJ +n/L95jheEX7dLPEh/epPQHVKlEi8xCmV+wJHZEPPagvz0buEUPWtFdLjd62W3bf+6fG 508H4ZWo4wXln76/rmm6XCGc0g2ExjDb3P9LI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=ghfGqhD8kSPkzEaBxEruXMB7IthRtVDWHZPHprti53xe+tlG/PSSQahbQtC4BC/UIe 5EtRlipzQoBATe83Ay02hM+fDBvd3g+rG8jEj4t0Z9RhkGTRsn5CA58y+5ReGPN0IoEV BgkTz34Pc5bAQ7DLb4cbM6YMefEc3NhBplCDY= Received: by 10.66.245.2 with SMTP id s2mr2362748ugh.80.1214241179882; Mon, 23 Jun 2008 10:12:59 -0700 (PDT) Received: by 10.66.245.3 with HTTP; Mon, 23 Jun 2008 10:12:59 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2008 19:12:59 +0200 To: "Steph Fox" Cc: "Greg Beaver" , "Marcus Boerger" , internals In-Reply-To: <01b401c8d548$0c0e1430$4401a8c0@foxbox> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <028a01c8d4a7$18dd4380$4401a8c0@foxbox> <008601c8d524$41184e30$4401a8c0@foxbox> <017401c8d53e$de2a9380$4401a8c0@foxbox> <01b401c8d548$0c0e1430$4401a8c0@foxbox> Subject: Re: [PHP-DEV] OpenSSL and Phar From: pierre.php@gmail.com ("Pierre Joye") On Mon, Jun 23, 2008 at 5:44 PM, Steph Fox wrote: >> My main question now is why don't you actually reflect the (optional) >> dependencies? bz2 and zlib compression available will not be available >> if bz2 or zlib is not present, same for openssl. > > What do you mean? In config.w32? No need. In phpinfo()? We already do, just > haven't added the openssl part yet because the configuration's up in the > air. Yes, in config.w32 and config.m4. Either using ADD_EXTENSION_DEP or ADD_LIBS if you use the library directly. phar works smoothly without them, fine, that makes them optional deps. But they are still dependencies. >> As testing has_xxx at runtime looks shiny and powerful, I don't think >> it is worth the pain. > > Sorry, I failed to parse that sentence... :\ You know how a given feature is tested in phar? PHAR_G(has_zlib) = zend_hash_exists(&module_registry, "zlib", sizeof("zlib")); then: if (!PHAR_G(has_zlib)) ... -- Pierre http://blog.thepimp.net | http://www.libgd.org