Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:38538 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48339 invoked from network); 23 Jun 2008 11:43:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jun 2008 11:43:17 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.235 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.198.235 rv-out-0506.google.com Received: from [209.85.198.235] ([209.85.198.235:14558] helo=rv-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DE/E9-23032-35C8F584 for ; Mon, 23 Jun 2008 07:43:16 -0400 Received: by rv-out-0506.google.com with SMTP id g37so7891586rvb.23 for ; Mon, 23 Jun 2008 04:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=fmIjc0qZhbun7ykPr6HGUaFpezuseKO6/pndv3kNYRc=; b=CcliS7wSmLqKpqvFd5DiNXuyTnYJIeOF86DnqZ4/idH+Bh23F6cBH16mN0jlpukR5E 1ecGba7aJOYTjwnRYdzjkRjQ3MrVLLn1ix/438mwB96k8Jjxw/nHc/U6uDKSkofCjwrN R86c+kPmOR45ojV3gJxARkm+VMGvTaNWjOx04= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=VW+YJkvgKqY8gywrNVx31xAaxvEJDf7AlgXGipHaeTKU4jlkFxZqfKYH3sYkpzFSUm 7IP/LD3N/00kAIGxRvwYjUMALndHoZ+DNhTjO1tcVcWGBrjhO4Np0eg5BncBbuprCMMh +bhk9GVywCxLWBzxMoA44w7gwbsk5a77igzK4= Received: by 10.141.5.3 with SMTP id h3mr12578411rvi.138.1214221392926; Mon, 23 Jun 2008 04:43:12 -0700 (PDT) Received: by 10.140.178.14 with HTTP; Mon, 23 Jun 2008 04:43:12 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2008 13:43:12 +0200 To: "Steph Fox" Cc: "Greg Beaver" , "Marcus Boerger" , internals In-Reply-To: <008601c8d524$41184e30$4401a8c0@foxbox> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <028a01c8d4a7$18dd4380$4401a8c0@foxbox> <008601c8d524$41184e30$4401a8c0@foxbox> Subject: Re: [PHP-DEV] OpenSSL and Phar From: pierre.php@gmail.com ("Pierre Joye") On Mon, Jun 23, 2008 at 1:28 PM, Steph Fox wrote: > You're missing that Windows users don't tend to roll their own PHP. They > tend to pick and choose their extensions. I still miss your point here, I was only talking about bins releases for windows. > At present, if someone were to load php_openssl.dll from PECL From PECL? it is in our releases and will remain in our releases, just like all extensions. > alongside > built-in Phar in 5.3 they'd probably wonder why it wasn't working as > advertised. If the dependency were made explicit in Phar, the only thing > ext/openssl would be needed for is explicit openssl calls - which is far > easier to understand. --enable-phar-ssl and do (not tested but it gives the idea): if (PHP_PHAR_SSL == "yes") { ADD_EXTENSION_DEP("phar", "openssl", true); } else { if (PHP_PHAR_SSL != "no") { // be sure to do not enable it when --disable-phar-ssl is used ADD_EXTENSION_DEP("phar", "openssl", true); } } > FWIW, I think having Phar built-in is actually a disadvantage when it comes > to this kind of thing. ext/openssl isn't enabled by default and is only > available as shared to the vast majority of Windows users. it is enabled by default and it is built shared as almost all extensions. The rest is a matter of documenting it, like almost all extensions, "please enable phar and openssl (if available) in your php.ini". Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org