Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38501
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 38.99.98.18 cause and error)
Message-ID: <485D6373.9000902@chiaraquartet.net>
Date: Sat, 21 Jun 2008 15:24:19 -0500
User-Agent: Thunderbird 2.0.0.14 (X11/20080505)
MIME-Version: 1.0
To: Jessie Hernandez <jrhernandez05@gmail.com>
CC: internals@lists.php.net, Andi Gutmans <andi@zend.com>, 
 Stanislav Malyshev <stas@zend.com>,
 Dmitry Stogov <dmitry@zend.com>
References: <485BD1C0.8040302@chiaraquartet.net> <485D5696.4070408@gmail.com>
In-Reply-To: <485D5696.4070408@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: simple solution to another namespace conundrum?
From: greg@chiaraquartet.net (Gregory Beaver)

Jessie Hernandez wrote:
> Hi Greg,
>
> How is this different from my original proposal
> (http://news.php.net/php.internals/34097,
> http://news.php.net/php.internals/34097)?
>
>

The patch committed only affects non-namespaced code, your proposal
affected all code.  In other words, this always works:

<?php
namespace Foo;
include 'blah.php';
use Blah::Closure;
$a = new Closure();
?>

whereas this:

<?php
include 'blah.php';
use Blah::Closure;
$a = new Closure();
?>

had the potential to fail with fatal error without code change on
upgrade to a newer PHP version that creates the "Closure" class.  The
committed patch addresses only this shortcoming, and changes nothing else.

In other words, this:

<?php
namespace Foo;
$a = new Exception('hi');
var_dump(get_class($a));
?>

still prints "Exception" and not "Foo::Exception".

Additionally, unlike your proposal, all existing namespace tests still
pass with the behavior change.  2 new tests were added, 1 to test the
relaxed behavior, and 1 to test that this next example is a fatal error
because definition of Foo::Closure is in the same file as the "use
Blah::Closure":

<?php
namespace Foo;
include 'blah.php';
class Closure{}
use Blah::Closure; // unqualified name "Closure" is already taken, fatal
error.
?>

Greg