Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38470
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.200.168 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version
         :content-type:references:x-google-sender-auth;
        b=DQXISVhqvYbBDDBpacl96SPXwXfHFBjuYXTnkbJ4xBEV5n1d+Z5aE4O9+gpXq+idQw
         LbjVVic2zaElf/UiaYaSJ/ZANg6Oa7WxCWo0VW06mdfGbDfdd/rCJrSf1HQT9QXekEV+
         unK0ozjscag5akUN6dy3MQwv9xrtabgcSsp68=
Message-ID: <b5f7bf6c0806200818i10caa7e8g24214d5d1459d77a@mail.gmail.com>
Date: Fri, 20 Jun 2008 16:18:50 +0100
Sender: david.coallier@gmail.com
To: "Stanislav Malyshev" <stas@zend.com>
Cc: "PHP Internals" <internals@lists.php.net>
In-Reply-To: <485AE658.3050204@zend.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; 
	boundary="----=_Part_7487_5273323.1213975130281"
References: <485AE658.3050204@zend.com>
Subject: Re: [PHP-DEV] cleaning up the functions - any volunteers?
From: davidc@php.net ("David Coallier")

------=_Part_7487_5273323.1213975130281
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

I'll take a few

2008/6/20 Stanislav Malyshev <stas@zend.com>:

> Hi!
>
> While we nearing the release of 5.3 (hopefully?), there are many functions
> in the PHP code which still use old parameter parsing API
> (zend_get_parameters_ex) instead of the new one (zend_parse_parameters).
>
> I have cleaned up Zend engine functions, converting them to the new API,
> but there are about 1000 instances throughout PHP code (especially
> ext/standard) which still use the old way. This way is less correct,
> inconsistent with the new code, gives worse error messages, more prone to
> various bugs, etc. All new extensions and functions use the new way, and the
> only reason for keeping the old way in the code seems to be that nobody
> cleaned it up. Somebody has to bring the old ones into sync, and I don't
> think I personally will have time to do it in near timeframe. So if anybody
> could step up to that - by doing at least part of the work - that'd be
> great. The work is pretty simple, taking something like:
>
> zval **data;
>
> if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &data) == FAILURE) {
>        WRONG_PARAM_COUNT;
> }
> convert_to_string_ex(data);
>
> and move it into:
>
> char *str;
> int str_len;
>
> if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &str, &str_len)
> == FAILURE) {
>        return;
> }
>
> and of course convert use of data zval into use of str.
>
> This needs to be done carefully as not to break things on some more tricky
> functions which may get arguments of multiple types, etc. Also, some tests
> which check error messages may need to be fixed since new API gives more
> detailed messages.
> zend_parse_parameters documented here:
> http://www.php.net/manual/en/internals2.ze1.zendapi.php
> though some of the newer parameters aren't (C, h, f, Z) so one may need to
> look at the code at zend_API.c.
>
> P.S. if some genius would invent a script to automate that - it'd be
> awesome, but I don't have very high hopes on that. :)
> --
> Stanislav Malyshev, Zend Software Architect
> stas@zend.com   http://www.zend.com/
> (408)253-8829   MSN: stas@zend.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
Slan,
David

------=_Part_7487_5273323.1213975130281--