Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:38432 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 79512 invoked from network); 19 Jun 2008 19:12:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jun 2008 19:12:31 -0000 Authentication-Results: pb1.pair.com smtp.mail=steph@phparch.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=steph@phparch.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain phparch.com from 64.99.136.187 cause and error) X-PHP-List-Original-Sender: steph@phparch.com X-Host-Fingerprint: 64.99.136.187 smtprelay-virgin0187.hostedemail.com Linux 2.5 (sometimes 2.4) (4) Received: from [64.99.136.187] ([64.99.136.187:38155] helo=smtprelay-virgin.hostedemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C4/A4-57468-D9FAA584 for ; Thu, 19 Jun 2008 15:12:30 -0400 Received: from filter.hostedemail.com (ff-bigip1 [10.5.19.254]) by smtprelay05.hostedemail.com (Postfix) with SMTP id 6480ABFDD; Thu, 19 Jun 2008 19:12:26 +0000 (UTC) X-SpamScore: 1 Received: from foxbox (host86-143-244-1.range86-143.btcentralplus.com [86.143.244.1]) (Authenticated sender: steph.fox) by omf10.hostedemail.com (Postfix) with ESMTP; Thu, 19 Jun 2008 19:12:25 +0000 (UTC) Message-ID: <061e01c8d240$9b509ab0$4401a8c0@foxbox> Reply-To: "Steph Fox" To: "Stanislav Malyshev" Cc: "internals" References: <04a501c8d181$e67c6ec0$4401a8c0@foxbox> <485A9AC3.3050603@zend.com> <05db01c8d23b$7fe3fb50$4401a8c0@foxbox> <485AA7CB.5040503@zend.com> <060801c8d23d$e3823b20$4401a8c0@foxbox> <485AAC3C.3080602@zend.com> Date: Thu, 19 Jun 2008 20:13:47 +0100 Organization: php|architect MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2180 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 X-session-marker: 73746570682E666F78 X-Spam-Summary: 50,0,0,85f02d803ad49e4f,04500b467597ecf3,steph@phparch.com,,RULES_HIT:152:355:379:539:540:541:542:543:567:599:601:800:967:973:980:988:989:1042:1155:1156:1260:1277:1311:1313:1314:1345:1437:1515:1516:1518:1534:1541:1587:1593:1594:1676:1711:1730:1747:1766:1792:2073:2075:2078:2380:2393:2525:2560:2564:2682:2685:2857:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3027:3352:3865:3867:3868:3870:3871:3872:3873:3934:3936:3938:3941:3944:3947:3950:4321:4886:5007:6119:6261:7679:7875,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:none,DNSBL:none Subject: Re: [PHP-DEV] [PATCH] unix path separators in spl From: steph@phparch.com ("Steph Fox") Hi Stas, >> Doesn't PATH_SEPARATOR use DEFAULT_SLASH? > > Should be DIRECTORY_SEPARATOR Bleh, must be nearly switching-off time > and it's "\" on windows (PATH_SEPARATOR is ";" ). Do you propose to change > it to "/"? dirsep_str[0] = DEFAULT_SLASH; dirsep_str[1] = '\0'; REGISTER_STRING_CONSTANT("DIRECTORY_SEPARATOR", dirsep_str, CONST_CS|CONST_PERSISTENT); >>> Path comparison is important. >> >> I thought so too until I couldn't find any broken tests. > > With all due respect to phpt, these are very primitive code samples > testing very narrow functional areas. They do not come anywhere near the > stuff people do in real-life apps, combining different functions and > extensions. Fair point. I like Marcus' idea tho'. - Steph > -- > Stanislav Malyshev, Zend Software Architect > stas@zend.com http://www.zend.com/ > (408)253-8829 MSN: stas@zend.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >