Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38407
Return-Path: <tswicegood@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 30346 invoked from network); 19 Jun 2008 15:06:10 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 19 Jun 2008 15:06:10 -0000
Authentication-Results: pb1.pair.com header.from=tswicegood@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=tswicegood@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 208.113.200.5 as permitted sender)
X-PHP-List-Original-Sender: tswicegood@php.net
X-Host-Fingerprint: 208.113.200.5 lax-green-bigip-5.dreamhost.com Linux 2.4/2.6
Received: from [208.113.200.5] ([208.113.200.5:37799] helo=spaceymail-a4.g.dreamhost.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id B1/38-10717-DD57A584 for <internals@lists.php.net>; Thu, 19 Jun 2008 11:06:05 -0400
Received: from [127.0.0.1] (7up.dreamhost.com [208.97.167.14])
	by spaceymail-a4.g.dreamhost.com (Postfix) with ESMTP id D6A31161AE1;
	Thu, 19 Jun 2008 08:06:00 -0700 (PDT)
In-Reply-To: <042d01c8d215$30e50240$4401a8c0@foxbox>
References: <04ba01c8d183$14f01b20$4401a8c0@foxbox> <4859D6B1.9030207@oracle.com> <00f601c8d1fb$fe5a8200$4401a8c0@foxbox> <49630731E5C64725B38BADFF04778684@pc07654> <03a001c8d205$157556a0$4401a8c0@foxbox> <C544EF8E-BD26-4F89-93A3-F83C19060CBB@php.net> <040501c8d210$1e464310$4401a8c0@foxbox> <9EB1CAAF-40B6-47C8-9DE8-510F5F23EF37@php.net> <042d01c8d215$30e50240$4401a8c0@foxbox>
Mime-Version: 1.0 (Apple Message framework v753.1)
X-Priority: 3
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <2A8C17AE-538B-4A21-95B4-D9D1167EE120@php.net>
Cc: "internals" <internals@lists.php.net>
Content-Transfer-Encoding: 7bit
Date: Thu, 19 Jun 2008 10:05:54 -0500
To: "Steph Fox" <steph@phparch.com>
X-Mailer: Apple Mail (2.753.1)
Subject: Re: [PHP-DEV] [PATCH] make it possible to skip very slow tests
From: tswicegood@php.net (Travis Swicegood)

On Jun 19, 2008, at 9:03 AM, Steph Fox wrote:

>
>> There's nothing wrong with that approach.  I'm trying to find   
>> something that addresses the problem (i.e., "how can I not run  
>> tests  that are going to take a long time to run?"), while  
>> providing enough  flexibility to answer other problems (i.e., "how  
>> can I skip X tests  that I don't care about?").
>>
>> If there's a way to address the problem without making it so   
>> specific, I'm all for it.
>
> I mostly agree - I'm just looking at 'here and now' rather than  
> 'when the nice new test suite stuff is done'. 'Here and now', there  
> isn't a reliable way to set this up and skipif looks like the  
> cleanest option.

The only problem with that is everything you add I've got to add to  
my GSoC project so PHPT :-)

> That might not be a bad idea.

I think the long-term goal should be the ability to "force skip"  
files based on an --exclude parameter, an ini conf file (looks for -- 
ini-file <file> or <cwd>/tests.ini), and an ENV variable.  The first  
and last would just be separated by the PATH_SEPARATOR for regex  
patterns.

In addition, we can definitely make the time-out something that's  
settable via the command line and conf, but as you noted in your next  
email, that is a separate issue.

I've created a few tickets on these so we can make sure to track  
these issues:
* add exclude: http://phpt.info/ticket/69
* add timeout: http://phpt.info/ticket/70

-T