Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38404
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain phparch.com from 64.99.136.188 cause and error)
Message-ID: <044101c8d21c$23190a60$4401a8c0@foxbox>
Reply-To: "Steph Fox" <steph@phparch.com>
To: "Christopher Jones" <christopher.jones@oracle.com>
Cc: "Travis Swicegood" <tswicegood@php.net>,
	"Nuno Lopes" <nlopess@php.net>,
	"internals" <internals@lists.php.net>
References: <04ba01c8d183$14f01b20$4401a8c0@foxbox> <4859D6B1.9030207@oracle.com> <00f601c8d1fb$fe5a8200$4401a8c0@foxbox> <49630731E5C64725B38BADFF04778684@pc07654> <03a001c8d205$157556a0$4401a8c0@foxbox> <C544EF8E-BD26-4F89-93A3-F83C19060CBB@php.net> <040501c8d210$1e464310$4401a8c0@foxbox> <485A6DB2.6060904@oracle.com>
Date: Thu, 19 Jun 2008 15:52:45 +0100
Organization: php|architect
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] make it possible to skip very slow tests
From: steph@phparch.com ("Steph Fox")


Hi Chris,

> If we make the timeout value adjustable, you can set it to a low value
> so your slow tests are quickly aborted, and I can set it to a high
> value so my tests are run.

It's easily enough done, it's just a separate issue.

I can easily put a workaround in the Windows version of select.c to make a 
0-second timeout work, but that's as far as it goes. The problem in 
run-tests (if anyone's interested - Travis seems to have a better solution) 
is that the actual read is always only 8192 bytes, and the actual API call 
never times out because stream_select() is reset at every iteration and 
called afresh. We'd need to be able to set a timeout limit in the run-tests 
script rather than in the call to stream_select(). And if we do that the 
tests of course fail, which isn't a good outcome.

So 'skipif' suits my needs better, but not yours. I'll add both.

- Steph

>
> Chris
>
> -- 
> Christopher Jones, Oracle
> Email: christopher.jones@oracle.com    Tel:  +1 650 506 8630
> Blog:  http://blogs.oracle.com/opal/   Free PHP Book: 
> http://tinyurl.com/f8jad