Newsgroups: php.internals,php.internals Path: news.php.net Xref: news.php.net php.internals:38396 php.internals:38400 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82112 invoked from network); 19 Jun 2008 13:43:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jun 2008 13:43:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=tswicegood@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=tswicegood@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 208.113.200.5 as permitted sender) X-PHP-List-Original-Sender: tswicegood@php.net X-Host-Fingerprint: 208.113.200.5 lax-green-bigip-5.dreamhost.com Linux 2.4/2.6 Received: from [208.113.200.5] ([208.113.200.5:58451] helo=spaceymail-a3.g.dreamhost.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5A/3E-10717-2826A584 for ; Thu, 19 Jun 2008 09:43:30 -0400 Received: from [127.0.0.1] (7up.dreamhost.com [208.97.167.14]) by spaceymail-a3.g.dreamhost.com (Postfix) with ESMTP id 82D77195569; Thu, 19 Jun 2008 06:43:27 -0700 (PDT) In-Reply-To: <040501c8d210$1e464310$4401a8c0@foxbox> References: <04ba01c8d183$14f01b20$4401a8c0@foxbox> <4859D6B1.9030207@oracle.com> <00f601c8d1fb$fe5a8200$4401a8c0@foxbox> <49630731E5C64725B38BADFF04778684@pc07654> <03a001c8d205$157556a0$4401a8c0@foxbox> <040501c8d210$1e464310$4401a8c0@foxbox> Mime-Version: 1.0 (Apple Message framework v753.1) X-Priority: 3 Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: <9EB1CAAF-40B6-47C8-9DE8-510F5F23EF37@php.net> Cc: internals Content-Transfer-Encoding: 7bit Date: Thu, 19 Jun 2008 08:43:22 -0500 To: "Steph Fox" X-Mailer: Apple Mail (2.753.1) Subject: Re: [PHP-DEV] [PATCH] make it possible to skip very slow tests From: tswicegood@php.net (Travis Swicegood) On Jun 19, 2008, at 8:26 AM, Steph Fox wrote: >> I can add this to PHPT - it uses a timeout based on reading the >> open proc. > > That's what the current run-tests does too. The problem is it isn't > reliable cross-platform - we don't have any control over the select > () function used by stream_select() except under Windows, where it > doesn't work (I'm looking into that but can't see why). This doesn't help you yet, but that's a moot point in PHPT as it uses COM under Windows as proc_* functions and the various stream functions are less than reliable. > So what was wrong with the simple skipif and env var approach > again? If you're going to mark a test to get run-tests to respond > to it, it doesn't make a lot of difference whether you mark that > test by its name or with a skipif line. The only difference is an > untidy CVS directory. There's nothing wrong with that approach. I'm trying to find something that addresses the problem (i.e., "how can I not run tests that are going to take a long time to run?"), while providing enough flexibility to answer other problems (i.e., "how can I skip X tests that I don't care about?"). If there's a way to address the problem without making it so specific, I'm all for it. > I think the naming thing would be a better idea for something > that's just starting out. It's a less good idea for a test suite > that already exists IMHO. Agreed. If we were to go this route, I'd actually consider adding a run-tests.ini or some such that allows you to configure things like excluded file patterns. -T