Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38393
Return-Path: <steph@phparch.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 72579 invoked from network); 19 Jun 2008 13:25:25 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 19 Jun 2008 13:25:25 -0000
Authentication-Results: pb1.pair.com smtp.mail=steph@phparch.com; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=steph@phparch.com; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain phparch.com from 64.99.136.140 cause and error)
X-PHP-List-Original-Sender: steph@phparch.com
X-Host-Fingerprint: 64.99.136.140 smtprelay-virgin0140.hostedemail.com Linux 2.5 (sometimes 2.4) (4)
Received: from [64.99.136.140] ([64.99.136.140:35008] helo=smtprelay-virgin.hostedemail.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 85/1C-10717-44E5A584 for <internals@lists.php.net>; Thu, 19 Jun 2008 09:25:24 -0400
Received: from filter.hostedemail.com (ff-bigip1 [10.5.19.254])
	by smtprelay07.hostedemail.com (Postfix) with SMTP id C89D111317A;
	Thu, 19 Jun 2008 13:25:21 +0000 (UTC)
X-SpamScore: 1
Received: from foxbox (host86-143-244-1.range86-143.btcentralplus.com [86.143.244.1])
	(Authenticated sender: steph.fox)
	by omf13.hostedemail.com (Postfix) with ESMTP;
	Thu, 19 Jun 2008 13:25:20 +0000 (UTC)
Message-ID: <040501c8d210$1e464310$4401a8c0@foxbox>
Reply-To: "Steph Fox" <steph@phparch.com>
To: "Travis Swicegood" <tswicegood@php.net>
Cc: "Nuno Lopes" <nlopess@php.net>,
	"Christopher Jones" <christopher.jones@oracle.com>,
	"internals" <internals@lists.php.net>
References: <04ba01c8d183$14f01b20$4401a8c0@foxbox> <4859D6B1.9030207@oracle.com> <00f601c8d1fb$fe5a8200$4401a8c0@foxbox> <49630731E5C64725B38BADFF04778684@pc07654> <03a001c8d205$157556a0$4401a8c0@foxbox> <C544EF8E-BD26-4F89-93A3-F83C19060CBB@php.net>
Date: Thu, 19 Jun 2008 14:26:42 +0100
Organization: php|architect
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.2180
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180
X-session-marker: 73746570682E666F78
X-Spam-Summary: 2,0,0,ff83046a557699b4,fe07710d8ac72b08,steph@phparch.com,,RULES_HIT:355:379:539:540:541:542:543:567:599:601:945:960:967:973:980:988:989:1155:1156:1260:1277:1311:1313:1314:1345:1437:1515:1516:1518:1534:1541:1587:1593:1594:1711:1730:1747:1766:1792:2073:2075:2078:2198:2199:2393:2525:2559:2563:2682:2685:2828:2857:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3027:3353:3865:3866:3867:3868:3869:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:4250:4470:4886:5007:6117:6119:6261:7679:7862:7875:7903,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:none,DNSBL:none
Subject: Re: [PHP-DEV] [PATCH] make it possible to skip very slow tests
From: steph@phparch.com ("Steph Fox")


> I can add this to PHPT - it uses a timeout based on reading the open 
> proc.

That's what the current run-tests does too. The problem is it isn't reliable 
cross-platform - we don't have any control over the select() function used 
by stream_select() except under Windows, where it doesn't work (I'm looking 
into that but can't see why).

> The only problem is that it is currently treated as an error.   I could 
> maybe add a new reporting level of timeout, though I do like  the idea of 
> having some sort of meta-data to conditionally skip tests.
>
> Maybe a better solution is to add an --exclude <pattern> and ask  people 
> to either place potentially slow tests in tests/slow/, or name  then <test 
> case>.slow.phpt?  Being able to exclude a pattern of test  names 
> definitely has more use than just setting a timeout.

So what was wrong with the simple skipif and env var approach again? If 
you're going to mark a test to get run-tests to respond to it, it doesn't 
make a lot of difference whether you mark that test by its name or with a 
skipif line. The only difference is an untidy CVS directory.

I think the naming thing would be a better idea for something that's just 
starting out. It's a less good idea for a test suite that already exists 
IMHO.

- Steph

>
> Thoughts?
>
> -T
>
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>