Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38390
Return-Path: <tswicegood@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 62196 invoked from network); 19 Jun 2008 13:14:35 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 19 Jun 2008 13:14:35 -0000
Authentication-Results: pb1.pair.com header.from=tswicegood@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=tswicegood@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 208.113.200.5 as permitted sender)
X-PHP-List-Original-Sender: tswicegood@php.net
X-Host-Fingerprint: 208.113.200.5 lax-green-bigip-5.dreamhost.com Linux 2.4/2.6
Received: from [208.113.200.5] ([208.113.200.5:58788] helo=spaceymail-a6.g.dreamhost.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id F9/C9-10717-ABB5A584 for <internals@lists.php.net>; Thu, 19 Jun 2008 09:14:35 -0400
Received: from [127.0.0.1] (7up.dreamhost.com [208.97.167.14])
	by spaceymail-a6.g.dreamhost.com (Postfix) with ESMTP id 69D55CA7D9;
	Thu, 19 Jun 2008 06:14:31 -0700 (PDT)
In-Reply-To: <03a001c8d205$157556a0$4401a8c0@foxbox>
References: <04ba01c8d183$14f01b20$4401a8c0@foxbox> <4859D6B1.9030207@oracle.com> <00f601c8d1fb$fe5a8200$4401a8c0@foxbox> <49630731E5C64725B38BADFF04778684@pc07654> <03a001c8d205$157556a0$4401a8c0@foxbox>
Mime-Version: 1.0 (Apple Message framework v753.1)
X-Priority: 3
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <C544EF8E-BD26-4F89-93A3-F83C19060CBB@php.net>
Cc: "Nuno Lopes" <nlopess@php.net>,
	"Christopher Jones" <christopher.jones@oracle.com>,
	"internals" <internals@lists.php.net>
Content-Transfer-Encoding: 7bit
Date: Thu, 19 Jun 2008 08:14:26 -0500
To: "Steph Fox" <steph@phparch.com>
X-Mailer: Apple Mail (2.753.1)
Subject: Re: [PHP-DEV] [PATCH] make it possible to skip very slow tests
From: tswicegood@php.net (Travis Swicegood)

On Jun 19, 2008, at 7:07 AM, Steph Fox wrote:

>
>> Yes, it is. Check the system_with_timeout() function in the run- 
>> tests.php script.
>> There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You  
>> would just need to make it configurable by some environment var.
>
> I already tried hard-coding both tv_sec and tv_usec to 0 and it  
> makes no difference here.

I can add this to PHPT - it uses a timeout based on reading the open  
proc.  The only problem is that it is currently treated as an error.   
I could maybe add a new reporting level of timeout, though I do like  
the idea of having some sort of meta-data to conditionally skip tests.

Maybe a better solution is to add an --exclude <pattern> and ask  
people to either place potentially slow tests in tests/slow/, or name  
then <test case>.slow.phpt?  Being able to exclude a pattern of test  
names definitely has more use than just setting a timeout.

Thoughts?

-T