Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38328
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
Date: Tue, 17 Jun 2008 21:10:38 +0200
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <1178748433.20080617211038@marcus-boerger.de>
To: Christian Seiler <chris_se@gmx.net>, 
	Johannes Schlueter <johannes@schlueters.de>
CC: php-dev List <internals@lists.php.net>
In-Reply-To: <4857ACE1.3050501@gmx.net>
References: <4856A547.3080801@gmx.net> <1961603263.20080617120320@marcus-boerger.de> <4857ACE1.3050501@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP
From: helly@php.net (Marcus Boerger)

Hello Christian, Johannes,

Tuesday, June 17, 2008, 2:24:01 PM, you wrote:

> Hi Marcus,

> I now have revised my patch to include your suggestions:

> http://www.christian-seiler.de/temp/closures-php-5.3-2008-06-17-2.diff

> The changes to the previous version:

>   - \0 at the start of the compiled lambda function name is dropped.
>   - lambdas which are class members are now marked as final
>   - the generated name of the lambda is now also stored within the
>     op_array (before op_array->function_name was simply "lambda")
>   - your suggestions for code cleanups in zend_compile.c

>> Actually how does it integrate with reflection?

> Consider the following class:

> class Example {
>    private $x = 0;

>    public function getIncer () {
>      return function () {
>        $this->x++;
>      };
>    }

>    public function show () {
>      $this->reallyShow ();
>    }

>    protected function reallyShow () {
>      echo "{$this->x}\n";
>    }
> }

> Running

> Reflection::export(new ReflectionClass('Example'));

> will yield (among other things):

>    - Methods [4] {
>      Method [ <user> public method getIncer ] {
>        @@ /home/christian/dev/php5.3/c-tests/reflection.php 6 - 10
>      }

>      Method [ <user> final public method 
> __compiled_lambda_/home/christian/dev/php5.3/c-tests/reflection.php_0 ] {
>        @@ /home/christian/dev/php5.3/c-tests/reflection.php 7 - 9
>      }

>      Method [ <user> public method show ] {
>        @@ /home/christian/dev/php5.3/c-tests/reflection.php 12 - 14
>      }

>      Method [ <user> protected method reallyShow ] {
>        @@ /home/christian/dev/php5.3/c-tests/reflection.php 16 - 18
>      }
>    }

> So lambda functions appear simply as additional methods in the class,
> with their generated name.

> Of course, the ReflectionMethod / ReflectionFunction classes could be
> extended so that it provides and additional method isLambda() in order
> to determine whether a function actually is a lambda function. But I'd
> rather do that in a separate step and a separate patch.

Yep, Reflection details can and should be addressed separately.

I think the next step is confirming with the rest of the core team that we
all ewant this. IMO it has often enough been requested and your patch
solves every tiny piece that was missing so far. And if people agree then
unfortunately you need to provide a patch for HEAD first. Actually you
could do so just now.

Johannes, what's your take on this one for 5.3?


Best regards,
 Marcus