Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38184
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain phparch.com from 64.99.136.173 cause and error)
Message-ID: <00fd01c8cc83$035a49d0$4401a8c0@foxbox>
Reply-To: "Steph Fox" <steph@phparch.com>
To: =?Windows-1252?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>
Cc: "internals" <internals@lists.php.net>,
	"Andrei" <andrei@gravitonic.com>,
	"Dmitry Stogov" <dmitry@zend.com>
References: <006301c8cc72$1e6235f0$4401a8c0@foxbox> <1213270500.21247.20.camel@goldfinger.johannes.nop>
Date: Thu, 12 Jun 2008 12:54:01 +0100
Organization: php|architect
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="Windows-1252";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: Re: Fw: [PHP-DEV] Dummy calls for 5.3.0 up? [Was: HEAD testsbroken under Windows]
From: steph@phparch.com ("Steph Fox")


Hi Johannes,

> These can be easily emulated using PHP like
>  if (!function_exists("is_binary")) {
>    function is_binary($s) { return is_string($s); }
>  }
>
>> file_put_contents(FILE_BINARY)

Obviously... I was just thinking about the amount of stuff that would need 
to be added to that compatibility layer, and how it might affect 
portability. Not everyone uses PEAR and here we're more or less forcing a 
dependency on it, with the option being to knit one's own. Also, since many 
are only now moving from PHP 4, it seems a bit harsh to tell them they're 
going to have to change their code all over again in a couple of years' time 
for PHP 6 when they could be doing it all at one hit.

> Would a const FILE_BINARY = 0; be enough or would that break the
> function in some way (didn't check it)

#define PHP_FILE_TEXT 32
#define PHP_FILE_BINARY 64

And again, yes you can do it in userland code (FILE_TEXT, FILE_BINARY) and 
it harms nothing.

> as long as such an emulation is possible I'd prefer putting them in a
> compatibility layer (like PEAR PHP_Compat) using PHP instead of putting
> "useless" (mind the quotes ...) functions into PHP.

We'll have to agree to disagree over this...

- Steph