Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38182
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain phparch.com from 64.99.136.139 cause and error)
Message-ID: <006301c8cc72$1e6235f0$4401a8c0@foxbox>
Reply-To: "Steph Fox" <steph@phparch.com>
To: "internals" <internals@lists.php.net>
Cc: "Johannes Schlueter" <johannes@schlueters.de>,
	"Andrei" <andrei@gravitonic.com>,
	"Dmitry Stogov" <dmitry@zend.com>
Date: Thu, 12 Jun 2008 10:53:06 +0100
Organization: php|architect
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="utf-8";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Fw: [PHP-DEV] Dummy calls for 5.3.0 up? [Was: HEAD tests broken under Windows]
From: steph@phparch.com ("Steph Fox")


OK, I'm now seeing a pass rate that more or less matches the same tests run 
by the PHP 5 test script and PHP 5.3 binary.

FILE_BINARY is needed in two of seven calls to file_put_contents(). Get it 
wrong (either way) and you get a random warning or notice. It's completely 
non-portable too - it will only be accepted under PHP 6.

There is far too much of this kind of thing. Can we please consider adding 
dummies into at least 5.3.0 and possibly even the 5_2 branch for:

is_binary()
is_unicode()
file_put_contents(FILE_BINARY)

and any other major 'gotchas' that people can think of that will make it 
impossible to write future-compatible PHP 5 code?

Thanks,

- Steph


----- Original Message ----- 
From: "Steph Fox" <steph@phparch.com>
To: "internals" <internals@lists.php.net>
Sent: Thursday, June 12, 2008 3:32 AM
Subject: [PHP-DEV] HEAD tests broken under Windows


>
>
> Hi all,
>
> I'm hopeful that run-tests.php will now work as advertised under CVS HEAD 
> in most places. However it's still not right under Windows, and I finally 
> tracked that down to the fact that file_put_contents() in PHP 6 will 
> insist on creating a file with DOS line endings. The test files are 
> created from .phpt --FILE-- sections using file_put_contents(), so there 
> are a vast number of fails under doze due to an extra character in output 
> strings there.
>
> There's a *closed* PHP bug on this which was raised by Zoe over a year 
> ago, see http://bugs.php.net/bug.php?id=41609. For some obscure reason it 
> was seen as a documentation problem at the time. This is an extreme change 
> in behaviour, not a documentation problem, and needs proper analysis.
>
> Could someone please look into it?
>
> Thanks,
>
> - Steph
>
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
>