Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:38134 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65003 invoked from network); 10 Jun 2008 11:45:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jun 2008 11:45:22 -0000 Authentication-Results: pb1.pair.com smtp.mail=nlopess@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=nlopess@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 212.55.154.24 as permitted sender) X-PHP-List-Original-Sender: nlopess@php.net X-Host-Fingerprint: 212.55.154.24 relay4.ptmail.sapo.pt Linux 2.4/2.6 Received: from [212.55.154.24] ([212.55.154.24:43742] helo=sapo.pt) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 25/98-15621-0596E484 for ; Tue, 10 Jun 2008 07:45:22 -0400 Received: (qmail 27711 invoked from network); 10 Jun 2008 11:45:14 -0000 Received: from unknown (HELO sapo.pt) (10.134.37.162) by relay4 with SMTP; 10 Jun 2008 11:45:14 -0000 Received: (qmail 14572 invoked from network); 10 Jun 2008 11:45:14 -0000 X-AntiVirus: PTMail-AV 0.3-0.93.0 X-Scan-Status: AV clean (0.00559 seconds); AS clean (0.01568 seconds) Received: from unknown (HELO pc07654) (nunoplopes@sapo.pt@[82.155.73.165]) (envelope-sender ) by mta12 (qmail-ldap-1.03) with SMTP for ; 10 Jun 2008 11:45:14 -0000 Message-ID: To: "Dmitry Stogov" , "PHP Internals List" Cc: "Andi Gutmans" , "Stanislav Malyshev" References: <484E617D.6080508@zend.com> In-Reply-To: <484E617D.6080508@zend.com> Date: Tue, 10 Jun 2008 12:45:12 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Windows Mail 6.0.6001.18000 X-MimeOLE: Produced By Microsoft MimeOLE V6.0.6001.18000 Subject: Re: [PHP-DEV] [PATCH] Executor improvements From: nlopess@php.net ("Nuno Lopes") Out of curiosity, what's the slowdown without fastcall? Despite the potential slowdown, I still think this is the way to go. The engine isn't supposed to crash! Nuno ----- Original Message ----- From: "Dmitry Stogov" To: "PHP Internals List" Cc: "Andi Gutmans" ; "Stanislav Malyshev" Sent: Tuesday, June 10, 2008 12:11 PM Subject: [PHP-DEV] [PATCH] Executor improvements > Hi, > > The proposed patch for PHP improves the executor. > > At first it eliminates direct execute() recursion so the following > script won't produce SIGSEGV anymore (It'll produce memory overflow > error instead). > > function foo() { > foo(); > } > foo(); > ?> > > Note that in case some extension (e.q. xdebug) override zend_execute(), > VM will use recursive calls. > > At second executor now uses "fastcall" calling convention, and as result > it gives ~5% speedup on bench.php (~3.8 sec instead of ~4.0 sec) > > Any objections? > > Thanks. Dmitry.