Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:38131 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29543 invoked from network); 10 Jun 2008 09:11:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jun 2008 09:11:02 -0000 Authentication-Results: pb1.pair.com smtp.mail=michal.dziemianko@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=michal.dziemianko@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.158 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: michal.dziemianko@gmail.com X-Host-Fingerprint: 72.14.220.158 fg-out-1718.google.com Received: from [72.14.220.158] ([72.14.220.158:15501] helo=fg-out-1718.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 03/42-15621-5254E484 for ; Tue, 10 Jun 2008 05:11:02 -0400 Received: by fg-out-1718.google.com with SMTP id 16so1915606fgg.23 for ; Tue, 10 Jun 2008 02:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:mime-version:in-reply-to :references:content-type:message-id:content-transfer-encoding:from :subject:date:to:x-mailer; bh=nKr//yvGkofBRR1rjdv88pMzBp405HAN++kkCMOaTQM=; b=dSMY/iCLuMRWgtOurh38YNSdPw0V561TS1QhTyoahDjLDENdoje4Rhn0jGzktwpOGz hAhe1Cpn2WvH9U1Mld5+nrZZbfdxh20RbehU1Wt4mTlm+G1cuhCxzS2fCDCl3yzFt96k BA7pdJ7oSgLVqpnd4JrnB8K8U0jg41V0dsxic= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:content-type:message-id :content-transfer-encoding:from:subject:date:to:x-mailer; b=R7zzfAmat2bXjMfc5zQHy2DLc9IB4x6BSXlmwd59G5cN5BOm08R/nu87RJAi3JoMKN bI3Nr8JNxJ+jtRzR4IBp6E5Fk5B7HpGjHE9NI05qVJhiWp0G5oS1ulYvMXLYp3P6/dv5 L/Tb231s8UBo276ytPL2ex4sDXFz5wChgOzYU= Received: by 10.103.247.14 with SMTP id z14mr3114261mur.39.1213089058243; Tue, 10 Jun 2008 02:10:58 -0700 (PDT) Received: from ?129.215.48.228? ( [129.215.48.228]) by mx.google.com with ESMTPS id y6sm5117061mug.15.2008.06.10.02.10.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 10 Jun 2008 02:10:56 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v753.1) In-Reply-To: <484D336E.1090206@daylessday.org> References: <7E62CA6E-83F4-4F9C-86FB-75EBE7D489C9@gmail.com> <484D336E.1090206@daylessday.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: Content-Transfer-Encoding: 7bit Date: Tue, 10 Jun 2008 10:04:15 +0100 To: internals@lists.php.net X-Mailer: Apple Mail (2.753.1) Subject: Re: [PHP-DEV] Algorithm Optimizations - string search From: michal.dziemianko@gmail.com (Michal Dziemianko) On 2008-06-09, at 14:43, Antony Dovgal wrote: > On 09.06.2008 15:39, Michal Dziemianko wrote: >> Hello, >> Here: http://212.85.117.53/DIFF.txt is small patch that will >> speed up following functions: >> strpos, >> stripos, >> strrpos >> strripos, >> and probably some others (all that use zend_memnstr/php_memnstr >> function) > > The code below is definitely wrong. > The pointers (haystack_dup & needle_dup) that were freed in the > previous version are not freed anymore, but I can see that they are > still allocated, so you have a memleak there. Hi Antony, Will correct it in a minute! and will be more careful:) Cheers Michal