Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38115
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain macvicar.net from 193.227.246.108 cause and error)
Message-ID: <484D2F94.7090106@macvicar.net>
Date: Mon, 09 Jun 2008 14:26:44 +0100
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: Michal Dziemianko <michal.dziemianko@gmail.com>
CC: internals@lists.php.net
References: <7E62CA6E-83F4-4F9C-86FB-75EBE7D489C9@gmail.com>
In-Reply-To: <7E62CA6E-83F4-4F9C-86FB-75EBE7D489C9@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam_Report: Spam detection software, running on the system "lovelace.midden.org.uk", has
	identified this incoming email as possible spam.  The original message
	has been attached to this so you can view it (if it isn't spam) or label
	similar future email.  If you have any questions, see
	the administrator of that system for details.
	Content preview:  Hi Michal, Everything looks fine here and it applies cleanly,
	do you think you could make a patch against HEAD with this as well? I suspect
	it will be different due to Unicode. Scott [...] 
	Content analysis details:   (-4.2 points, 5.0 required)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.8 ALL_TRUSTED            Passed through trusted hosts only via SMTP
	0.1 TW_RR                  BODY: Odd Letter Triples with RR
	0.0 NORMAL_HTTP_TO_IP      URI: Uses a dotted-decimal IP address in URL
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
	0.1 AWL                    AWL: From: address is in the auto white-list
Subject: Re: [PHP-DEV] Algorithm Optimizations - string search
From: scott@macvicar.net (Scott MacVicar)

Hi Michal,

Everything looks fine here and it applies cleanly, do you think you 
could make a patch against HEAD with this as well? I suspect it will be 
different due to Unicode.

Scott

Michal Dziemianko wrote:
> Hello,
> Here: http://212.85.117.53/DIFF.txt  is small patch that will speed up 
> following functions:
> strpos,
> stripos,
> strrpos
> strripos,
> and probably some others (all that use zend_memnstr/php_memnstr function)
> 
> The speedup of zend_memnstr is about 8% on average (about 30% in case of 
> artificial strings).
> Functions strrpos and strripos are about 25% faster on average.
> 
> The only drawback - it needs some additional space (size of the needle).
> 
> All functions pass all the tests.
> 
> If it looks fine than I will apply for cvs account.
> 
> Cheers,
> Michal