Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38100
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
Date: Sat, 7 Jun 2008 21:10:46 +0200
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <1577220908.20080607211046@marcus-boerger.de>
To: Marcus Boerger <helly@php.net>
CC: "Henrique do N. Angelo" <h.n.angelo@gmail.com>, internals@lists.php.net
In-Reply-To: <1916347094.20080607164150@marcus-boerger.de>
References: <995e11c50806062325h565720edt1fdb288af72da07@mail.gmail.com> <1916347094.20080607164150@marcus-boerger.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Introduction and patches
From: helly@php.net (Marcus Boerger)

Hello Marcus,

  feel free to commit these. Please stay in touch with your mentor and the
rest of the team to discuss especially larger changes.

marcus

Saturday, June 7, 2008, 4:41:50 PM, you wrote:

> Hello Henrique,

>   this all looks fine.Can you apply for an account directly?

> marcus

> Saturday, June 7, 2008, 8:25:19 AM, you wrote:

>> Index: bug34704.phpt
>> ===================================================================
>> RCS file: /repository/php-src/ext/exif/tests/bug34704.phpt,v
>> retrieving revision 1.5
>> diff -u -r1.5 bug34704.phpt
>> --- bug34704.phpt       2 Jun 2006 22:22:42 -0000       1.5
>> +++ bug34704.phpt       7 Jun 2008 02:31:14 -0000
>> @@ -13,51 +13,22 @@
>>  ===DONE===
>>  --EXPECTF--
>>  array(7) {
>> -  ["FileName"]=>
>> -  string(12) "bug34704.jpg"
>> -  ["FileDateTime"]=>
>> -  int(%d)
>> -  ["FileSize"]=>
>> -  int(9976)
>> -  ["FileType"]=>
>> -  int(2)
>> -  ["MimeType"]=>
>> -  string(10) "image/jpeg"
>> -  ["SectionsFound"]=>
>> -  string(4) "IFD0"
>> -  ["COMPUTED"]=>
>> -  array(5) {
>> -    ["html"]=>
>> -    string(24) "width="386" height="488""
>> -    ["Height"]=>
>> -    int(488)
>> -    ["Width"]=>
>> -    int(386)
>> -    ["IsColor"]=>
>> -    int(1)
>> -    ["ByteOrderMotorola"]=>
>> -    int(0)
>> -  }
>> -}
>> -===DONE===
>> ---UEXPECTF--
>> -array(7) {
>>    [u"FileName"]=>
>> -  string(12) "bug34704.jpg"
>> +  unicode(12) "bug34704.jpg"
>>    [u"FileDateTime"]=>
>> -  int(1128867104)
>> +  int(%d)
>>    [u"FileSize"]=>
>>    int(9976)
>>    [u"FileType"]=>
>>    int(2)
>>    [u"MimeType"]=>
>> -  string(10) "image/jpeg"
>> +  unicode(10) "image/jpeg"
>>    [u"SectionsFound"]=>
>> -  string(4) "IFD0"
>> +  unicode(4) "IFD0"
>>    [u"COMPUTED"]=>
>>    array(5) {
>>      [u"html"]=>
>> -    string(24) "width="386" height="488""
>> +    unicode(24) "width="386" height="488""
>>      [u"Height"]=>
>>      int(488)
>>      [u"Width"]=>
>> Index: exif001.phpt
>> ===================================================================
>> RCS file: /repository/php-src/ext/exif/tests/exif001.phpt,v
>> retrieving revision 1.6
>> diff -u -r1.6 exif001.phpt
>> --- exif001.phpt        27 May 2008 18:16:00 -0000      1.6
>> +++ exif001.phpt        7 Jun 2008 02:31:14 -0000
>> @@ -19,7 +19,7 @@
>>    [u"FILE"]=>
>>    array(6) {
>>      [u"FileName"]=>
>> -    string(9) "test2.jpg"
>> +    unicode(9) "test2.jpg"
>>      [u"FileDateTime"]=>
>>      int(%d)
>>      [u"FileSize"]=>
>> @@ -27,14 +27,14 @@
>>      [u"FileType"]=>
>>      int(2)
>>      [u"MimeType"]=>
>> -    string(10) "image/jpeg"
>> +    unicode(10) "image/jpeg"
>>      [u"SectionsFound"]=>
>> -    string(33) "ANY_TAG, IFD0, THUMBNAIL, COMMENT"
>> +    unicode(33) "ANY_TAG, IFD0, THUMBNAIL, COMMENT"
>>    }
>>    [u"COMPUTED"]=>
>>    array(12) {
>>      [u"html"]=>
>> -    string(20) "width="1" height="1""
>> +    unicode(20) "width="1" height="1""
>>      [u"Height"]=>
>>      int(1)
>>      [u"Width"]=>
>> @@ -44,26 +44,26 @@
>>      [u"ByteOrderMotorola"]=>
>>      int(1)
>>      [u"UserComment"]=>
>> -    string(16) "Exif test image."
>> +    unicode(16) "Exif test image."
>>      [u"UserCommentEncoding"]=>
>> -    string(5) "ASCII"
>> +    unicode(5) "ASCII"
>>      [u"Copyright"]=>
>> -    string(41) "Photo (c) M.Boerger, Edited by M.Boerger."
>> +    unicode(41) "Photo (c) M.Boerger, Edited by M.Boerger."
>>      [u"Copyright.Photographer"]=>
>> -    string(19) "Photo (c) M.Boerger"
>> +    unicode(19) "Photo (c) M.Boerger"
>>      [u"Copyright.Editor"]=>
>> -    string(20) "Edited by M.Boerger."
>> +    unicode(20) "Edited by M.Boerger."
>>      [u"Thumbnail.FileType"]=>
>>      int(2)
>>      [u"Thumbnail.MimeType"]=>
>> -    string(10) "image/jpeg"
>> +    unicode(10) "image/jpeg"
>>    }
>>    [u"IFD0"]=>
>>    array(2) {
>>      [u"Copyright"]=>
>> -    string(19) "Photo (c) M.Boerger"
>> +    unicode(19) "Photo (c) M.Boerger"
>>      [u"UserComment"]=>
>> -    string(5) "ASCII"
>> +    unicode(5) "ASCII"
>>    }
>>    [u"THUMBNAIL"]=>
>>    array(2) {
>> @@ -75,10 +75,10 @@
>>    [u"COMMENT"]=>
>>    array(3) {
>>      [0]=>
>> -    string(11) "Comment #1."
>> +    unicode(11) "Comment #1."
>>      [1]=>
>> -    string(11) "Comment #2."
>> +    unicode(11) "Comment #2."
>>      [2]=>
>> -    string(13) "Comment #3end"
>> +    unicode(13) "Comment #3end"
>>    }
>>  }
>> Index: exif004.phpt
>> ===================================================================
>> RCS file: /repository/php-src/ext/exif/tests/exif004.phpt,v
>> retrieving revision 1.5
>> diff -u -r1.5 exif004.phpt
>> --- exif004.phpt        4 Jan 2003 19:19:59 -0000       1.5
>> +++ exif004.phpt        7 Jun 2008 02:31:14 -0000
>> @@ -22,17 +22,17 @@
>>  ?>
>>  --EXPECT--
>>  array(5) {
>> -  ["Subject"]=>
>> -  string(10) "Subject..."
>> -  ["Keywords"]=>
>> -  string(11) "Keywords..."
>> -  ["Author"]=>
>> -  string(9) "Rui Carmo"
>> -  ["Comments"]=>
>> -  string(29) "Comments
>> +  [u"Subject"]=>
>> +  unicode(10) "Subject..."
>> +  [u"Keywords"]=>
>> +  unicode(11) "Keywords..."
>> +  [u"Author"]=>
>> +  unicode(9) "Rui Carmo"
>> +  [u"Comments"]=>
>> +  unicode(29) "Comments
>>  Line2
>>  Line3
>>  Line4"
>> -  ["Title"]=>
>> -  string(8) "Title..."
>> +  [u"Title"]=>
>> +  unicode(8) "Title..."
>>  }
>> Index: exif005.phpt
>> ===================================================================
>> RCS file: /repository/php-src/ext/exif/tests/exif005.phpt,v
>> retrieving revision 1.8
>> diff -u -r1.8 exif005.phpt
>> --- exif005.phpt        27 May 2008 18:16:00 -0000      1.8
>> +++ exif005.phpt        7 Jun 2008 02:31:14 -0000
>> @@ -16,7 +16,7 @@
>>  --EXPECT--
>>  array(2) {
>>    [u"ImageDescription"]=>
>> -  string(11) "Ifd00000009"
>> +  unicode(11) "Ifd00000009"
>>    [u"DateTime"]=>
>> -  string(19) "2002:10:18 20:06:00"
>> +  unicode(19) "2002:10:18 20:06:00"
>>  }



> Best regards,
>  Marcus





Best regards,
 Marcus