Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38068
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain dynom.nl does not designate 85.92.132.6 as permitted sender)
Message-ID: <48439667.2040706@dynom.nl>
Date: Mon, 02 Jun 2008 08:42:47 +0200
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: Hannes Magnusson <hannes.magnusson@gmail.com>
CC: Stanislav Malyshev <stas@zend.com>, 
 PHP Internals <internals@lists.php.net>
References: <4842C9AF.6040803@zend.com>	 <7f3ed2c30806010943k79790024hf0e83bf5ea5a5340@mail.gmail.com>	 <4842D84D.50509@zend.com>	 <7f3ed2c30806011030q73608bfo40ce3bddbb80f56d@mail.gmail.com>	 <4842DFB2.8050002@zend.com> <7f3ed2c30806011432l51044d1dx68abfa28e22ad671@mail.gmail.com>
In-Reply-To: <7f3ed2c30806011432l51044d1dx68abfa28e22ad671@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] multiple use
From: mark@dynom.nl (Mark van der Velden)

Hannes Magnusson wrote:
> On Sun, Jun 1, 2008 at 7:43 PM, Stanislav Malyshev <stas@zend.com> wrote:
>> Hi!
>>
>>> use FooBar::In::Some::NameSpace as foo,
>>> SomeOther::Cool:Massive::awesome::space as bar, And::other:namespace
>>> as foobar;
>>> vs
>>> use FooBar::In::Some::NameSpace as foo;
>>> use SomeOther::Cool:Massive::awesome::space as bar;
>>> use And::other:namespace as foobar;
>> Well, with (im)proper formatting many things can be unreadable, but
>> use FooBar::In::Some::NameSpace             as foo,
>>    SomeOther::Cool:Massive::awesome::space as bar,
>>    And::other:namespace                    as foobar;
>>
>> doesn't seem unreadable at all to me. Repeating "use" is just clutter which
>> doesn't add anything. And btw not all names are that long - when I actually
>> used namespaces in the code, I found that it'd be much easier if I could
>> chain declarations. Just as it is easier to do $a = array(1,2,3) and not $a
>> = array(); $a[0] = 1; $a[1] = 2; $a[2] = 3;
> 
> I don't know what else I can say. You asked if someone had objections
> and I replied stating my personal opinion that I find explicit use
> statements in multiple lines more readable.
Perhaps it is. But like mentioned earlier, you can do it with multiple 
things already, it only makes sense adding that support to the use 
feature also.

> I don't really see the point in dropping three characters if you are
> going to indent it just the same anyway, doesn't even safe you a
> single keystroke..
I'd say use <tab> more often :->
You don't have to use it, it doesn't exclude the other.


> 
> -Hannes
> 


If it's not too much work, and if it doesn't break anything.
I'd say just add it, let's not counter every patch that makes it to the 
list.

- Mark