Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:38036 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40919 invoked from network); 1 Jun 2008 03:31:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Jun 2008 03:31:10 -0000 Authentication-Results: pb1.pair.com smtp.mail=greg@chiaraquartet.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=greg@chiaraquartet.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 38.99.98.18 cause and error) X-PHP-List-Original-Sender: greg@chiaraquartet.net X-Host-Fingerprint: 38.99.98.18 beast.bluga.net Linux 2.6 Received: from [38.99.98.18] ([38.99.98.18:45267] helo=mail.bluga.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 16/1B-54820-DF712484 for ; Sat, 31 May 2008 23:31:10 -0400 Received: from mail.bluga.net (localhost.localdomain [127.0.0.1]) by mail.bluga.net (Postfix) with ESMTP id E429DC12293 for ; Sat, 31 May 2008 20:31:11 -0700 (MST) Received: from [192.168.0.106] (CPE-76-84-4-101.neb.res.rr.com [76.84.4.101]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.bluga.net (Postfix) with ESMTP id A8D84C1228C for ; Sat, 31 May 2008 20:31:11 -0700 (MST) Message-ID: <48421811.2090307@chiaraquartet.net> Date: Sat, 31 May 2008 22:31:29 -0500 User-Agent: Thunderbird 2.0.0.14 (X11/20080505) MIME-Version: 1.0 To: internals Mailing List X-Enigmail-Version: 0.95.0 Content-Type: multipart/mixed; boundary="------------090506050104000409050001" X-Virus-Scanned: ClamAV using ClamSMTP Subject: [PATCH] fix building openssl shared on unix in 5.3 From: greg@chiaraquartet.net (Gregory Beaver) --------------090506050104000409050001 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi, I was trying to test building openssl shared, and ran into an unexported symbol issue because the arginfo constant arrays are never exported for dll/so use. Could someone check out this patch and make sure it doesn't fubar windows in particular? The same patch will apply in all branches just fine. Thanks, Greg --------------090506050104000409050001 Content-Type: text/plain; name="fixexport.patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fixexport.patch.txt" Index: Zend/zend_arg_defs.c =================================================================== RCS file: /repository/ZendEngine2/zend_arg_defs.c,v retrieving revision 1.2.2.2.2.2.2.1 diff -u -r1.2.2.2.2.2.2.1 zend_arg_defs.c --- Zend/zend_arg_defs.c 31 Dec 2007 07:17:04 -0000 1.2.2.2.2.2.2.1 +++ Zend/zend_arg_defs.c 1 Jun 2008 03:26:00 -0000 @@ -18,29 +18,29 @@ /* $Id: zend_arg_defs.c,v 1.2.2.2.2.2.2.1 2007/12/31 07:17:04 sebastian Exp $ */ -ZEND_BEGIN_ARG_INFO(first_arg_force_ref, 0) +ZEND_API ZEND_BEGIN_ARG_INFO(first_arg_force_ref, 0) ZEND_ARG_PASS_INFO(1) ZEND_END_ARG_INFO(); -ZEND_BEGIN_ARG_INFO(second_arg_force_ref, 0) +ZEND_API ZEND_BEGIN_ARG_INFO(second_arg_force_ref, 0) ZEND_ARG_PASS_INFO(0) ZEND_ARG_PASS_INFO(1) ZEND_END_ARG_INFO(); -ZEND_BEGIN_ARG_INFO(third_arg_force_ref, 0) +ZEND_API ZEND_BEGIN_ARG_INFO(third_arg_force_ref, 0) ZEND_ARG_PASS_INFO(0) ZEND_ARG_PASS_INFO(0) ZEND_ARG_PASS_INFO(1) ZEND_END_ARG_INFO(); -ZEND_BEGIN_ARG_INFO(fourth_arg_force_ref, 0) +ZEND_API ZEND_BEGIN_ARG_INFO(fourth_arg_force_ref, 0) ZEND_ARG_PASS_INFO(0) ZEND_ARG_PASS_INFO(0) ZEND_ARG_PASS_INFO(0) ZEND_ARG_PASS_INFO(1) ZEND_END_ARG_INFO(); -ZEND_BEGIN_ARG_INFO(fifth_arg_force_ref, 0) +ZEND_API ZEND_BEGIN_ARG_INFO(fifth_arg_force_ref, 0) ZEND_ARG_PASS_INFO(0) ZEND_ARG_PASS_INFO(0) ZEND_ARG_PASS_INFO(0) @@ -48,5 +48,5 @@ ZEND_ARG_PASS_INFO(1) ZEND_END_ARG_INFO(); -ZEND_BEGIN_ARG_INFO(all_args_by_ref, 1) +ZEND_API ZEND_BEGIN_ARG_INFO(all_args_by_ref, 1) ZEND_END_ARG_INFO(); --------------090506050104000409050001--