Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37905
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error)
Message-ID: <483B19DD.4060800@lerdorf.com>
Date: Mon, 26 May 2008 13:13:17 -0700
User-Agent: Thunderbird 2.0.0.4 (Macintosh/20070604)
MIME-Version: 1.0
To:  jani.taskinen@iki.fi
CC: internals Mailing List <internals@lists.php.net>
References: <483B16C1.7050907@sci.fi> <483B178E.9010106@lerdorf.com> <483B18A4.7010401@sci.fi>
In-Reply-To: <483B18A4.7010401@sci.fi>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Can not delete comments in bug reports
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Jani Taskinen wrote:
> Rasmus Lerdorf kirjoitti:
>> Jani Taskinen wrote:
>>> So who broke the deleting of comments in bug reports?
>>> It used to work fine, now nothing happens..
>>
>> Is that your way of filing a bug report?
> 
> :)
> 
>> I upgraded from MySQL 4.1.x to 5.1.x because 4.1 was very unstable for 
>> some reason.  It seems more stable now, but perhaps the delete query 
>> is doing something weird that 5.1 doesn't like.
> 
> Actually I just noticed that this only happens with some comments, not 
> all..maybe that table needs some loving care of "REPAIR TABLE"..?
> (or even all the tables?)

I upgraded and repaired all the tables, but I'll run it again.  It is 
reporting back:

| phpbugdb.bugdb_comments | repair | status   | OK       |

The code is:

         $query = "DELETE FROM bugdb_comments WHERE bug=$id AND id=$com_id";
         $res = @mysql_query($query);

I've removed the @ there.  Could you try again on one that didn't work 
before and let me know what error you see?

-R