Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37850
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain zend.com does not designate 64.97.136.175 as permitted sender)
Message-ID: <008f01c8bd9d$63f0cde0$4401a8c0@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "Andrei Zmievski" <andrei@gravitonic.com>
Cc: "Antony Dovgal" <tony@daylessday.org>,
	<internals@lists.php.net>
References: <7d6e34d80805191240k64cb1ba6k3e8f7a50ddf068c@mail.gmail.com> <4831F27B.7030001@suse.de> <296949B4-D328-49FE-968B-4942B28FE869@pooteeweet.org> <7d6e34d80805191454m69614624v7a05037fa947328e@mail.gmail.com> <698DE66518E7CA45812BD18E807866CE019F60DE@us-ex1.zend.net> <34.64.28995.1BE23384@pb1.pair.com> <02e701c8bab7$19a3dd10$4401a8c0@foxbox> <4833FD5B.2010308@daylessday.org> <003f01c8bb33$81ae5030$4401a8c0@foxbox> <48346ED3.9040505@gravitonic.com> <001501c8bbf6$5702cf50$4401a8c0@foxbox> <48371131.50003@gravitonic.com>
Date: Sat, 24 May 2008 13:55:03 +0100
Organization: Zend Technologies
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="UTF-8";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Unicode progress [Was: unicode.semantics ad infinitum]
From: steph@zend.com ("Steph Fox")

Hi Andrei,

I see where you're coming from over the (binary)|(string) issue, just trying 
to find some way that would preserve a little more back compatibility.

> UG(ascii_conv) is for the format string, not the arguments. The warning is 
> thrown by this code:
>
>       convert_to_string_ex(argv[currentarg]);
>
> It should check the arg type and return with a warning if it's Unicode.

OK, so there are some things that should maybe 'just happen' here, and also 
when 'S' is used:

PHP_NAMED_FUNCTION(php_if_crc32)
{
 char *p;
 int len, nr;
 php_uint32 crcinit = 0;
 register php_uint32 crc;

 if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "S", &p, &nr) == 
FAILURE) {
  return;
 }
...

Warning: crc32() expects parameter 1 to be strictly a binary string, Unicode 
string given in ...

Surely if a function's *expecting* a binary string it should do a silent 
conversion, and only throw a warning if the conversion fails? I don't see 
why the onus should always be on the user to adapt to this.

- Steph