Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37844
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error)
Message-ID: <4837776A.1080609@lerdorf.com>
Date: Fri, 23 May 2008 19:03:22 -0700
User-Agent: Thunderbird 2.0.0.4 (Macintosh/20070604)
MIME-Version: 1.0
To: Gregory Beaver <greg@chiaraquartet.net>
CC: Lars Strojny <lars@strojny.net>, Philip Olson <philip@roshambo.org>,
        internals Mailing List <internals@lists.php.net>
References: <5B2E59A9-BC46-447F-BEBC-C4149866A802@roshambo.org> <1211494158.7416.5.camel@localhost> <48360328.3040500@lerdorf.com> <483763D0.6000708@chiaraquartet.net>
In-Reply-To: <483763D0.6000708@chiaraquartet.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] magic quotes finale
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Gregory Beaver wrote:
> Rasmus Lerdorf wrote:
>> I see absolutely no reason to force people to go through and change:
>>
>> if(!get_magic_quotes_gpc())
>>
>> to:
>>
>> if (!function_exists('get_magic_quotes_gpc') || !get_magic_quotes_gpc())
>>
>> when there is no technical reason to force them to do so.  It is slower,
>> more verbose and completely useless.
> 
> I whole-heartedly agree.
> 
> To the others: please examine this from a practical instead of a
> philosophical position.
> 
> What is the problem that needs solving?
> 
>  * magic_quotes_gpc escapes input, which is bad.
> 
> How to fix it?
> 
>  * disable magic_quotes_gpc = on, disable set_magic_quotes_gpc(1)
> 
> Implicit in this statement is that the problem is *not*:
> 
>  * Users use get_magic_quotes_gpc() check whether this faulty ini is
> enabled, and set_magic_quotes_gpc(off) only if it is enabled.
> 
> If we take the step of removing the get_magic_quotes_gpc() function, or
> of adding an E_DEPRECATED, we make upgrading to PHP 5.3 harder, for no
> benefit.

Right, I guess I wasn't absolutely explicit.  There is no point in 
spewing an E_DEPRECATED on get_magic_quotes_gpc().  Such warnings should 
be for people actually using a deprecated feature, not for functions 
that check for those features.

-Rasmus