Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37843
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 38.99.98.18 cause and error)
Message-ID: <483763D0.6000708@chiaraquartet.net>
Date: Fri, 23 May 2008 19:39:44 -0500
User-Agent: Thunderbird 2.0.0.14 (X11/20080502)
MIME-Version: 1.0
To: Rasmus Lerdorf <rasmus@lerdorf.com>
CC: Lars Strojny <lars@strojny.net>, Philip Olson <philip@roshambo.org>, 
 internals Mailing List <internals@lists.php.net>
References: <5B2E59A9-BC46-447F-BEBC-C4149866A802@roshambo.org> <1211494158.7416.5.camel@localhost> <48360328.3040500@lerdorf.com>
In-Reply-To: <48360328.3040500@lerdorf.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] magic quotes finale
From: greg@chiaraquartet.net (Gregory Beaver)

Rasmus Lerdorf wrote:
> I see absolutely no reason to force people to go through and change:
> 
> if(!get_magic_quotes_gpc())
> 
> to:
> 
> if (!function_exists('get_magic_quotes_gpc') || !get_magic_quotes_gpc())
> 
> when there is no technical reason to force them to do so.  It is slower,
> more verbose and completely useless.

I whole-heartedly agree.

To the others: please examine this from a practical instead of a
philosophical position.

What is the problem that needs solving?

 * magic_quotes_gpc escapes input, which is bad.

How to fix it?

 * disable magic_quotes_gpc = on, disable set_magic_quotes_gpc(1)

Implicit in this statement is that the problem is *not*:

 * Users use get_magic_quotes_gpc() check whether this faulty ini is
enabled, and set_magic_quotes_gpc(off) only if it is enabled.

If we take the step of removing the get_magic_quotes_gpc() function, or
of adding an E_DEPRECATED, we make upgrading to PHP 5.3 harder, for no
benefit.

As a side note, the silent majority (developers who do not post to this
list) were represented at php|tek, and the few I spoke to about the way
magic_quotes is being handled unequivocally agreed with my assessment
for the exact same reasons.

I strongly encourage everyone to do a realistic tradeoff analysis and
come to understand why Rasmus's solution is the only possible solution
to this problem that both solves the *actual* problem and has real
benefit to existing well-written applications.

Thanks,
Greg