Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37813
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.234 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=Zcr1QV8rgZB2TiJVhdGt/V1jXS1KkbqsyCcd8EfLE0M32sFyk9tG1axsQ6/8LJGgcz2qIWm1TI7g+zzVgE/25Zq5V+wE5HnZcPLuB8FtedIajaXE33FjcRJmIK6JCT2wQaYm+KD8jdWOHWqh50FWOFp56CFRlSiQ4/T4kApwb6A=
Message-ID: <fe05d1540805221756j44618536x975919a187015071@mail.gmail.com>
Date: Fri, 23 May 2008 02:56:26 +0200
To: "Rasmus Lerdorf" <rasmus@lerdorf.com>
Cc: "Lars Strojny" <lars@strojny.net>, "Philip Olson" <philip@roshambo.org>, 
	"internals Mailing List" <internals@lists.php.net>
In-Reply-To: <48360328.3040500@lerdorf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <5B2E59A9-BC46-447F-BEBC-C4149866A802@roshambo.org>
	 <1211494158.7416.5.camel@localhost> <48360328.3040500@lerdorf.com>
Subject: Re: [PHP-DEV] magic quotes finale
From: pierre.php@gmail.com ("Pierre Joye")

Hi Rasmus,

On Fri, May 23, 2008 at 1:35 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> Lars Strojny wrote:
>>
>> [ forgot to sent that to the list ]
>>
>> Hi Philip,
>>
>> Am Dienstag, den 20.05.2008, 12:55 -0700 schrieb Philip Olson:
>> [...]
>>>
>>> PHP 5.3 is approaching fast, so let's conclude our dealings with  magical
>>> quotes... this should be the last time. Please have a look at  the following
>>> RFC and discuss it within this thread.
>>>
>>>   Magic Quotes in PHP 5.3 and beyond
>>>   - http://wiki.php.net/rfc/magicquotes
>>>
>>> It recommends changes to both 5_3 and 6_0 branches, namely, removing
>>>  E_DEPRECATED from the get_ magical quote functions. Silence means  you're
>>> okay with the RFC being implemented.
>>
>> Why should we leave get_magic_quotes_gpc()? If someone wants to be
>> backwards compatible, just use
>> if (function_exists('get_magic_quotes_gpc') and @get_magic_quotes_gpc())
>> Let's just add this to the manual, and everything is fine.
>>
>> I don't see a problem with this at all and it has the advantage of
>> allowing use to remove all the traces of magic quotes in 6. Magic quotes
>> are considered a bad practice for a long time.
>
> We have covered this a bunch of times already.  magic_quotes_gpc are gone,
> but we leave in the function that tells userspace code that they are off.
>  get_magic_quotes_gpc() will always return false which means that thousands
> of applications out there will run unchanged and will simply take the
> magic_quotes off code path.

Exactly, what I said in my very first reply to this thread. With all
respects to Philip, this RFC and discussion are pointless, the
solution has been approved and the problem is about to be solved (when
I get two and half mins to apply my patch, probably early next week).

Cheers,
-- 
Pierre
http://blog.thepimp.net | http://www.libgd.org