Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37812
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain roshambo.org from 207.210.105.50 cause and error)
Cc: internals Mailing List <internals@lists.php.net>
Message-ID: <0AB779D8-A64A-4CF8-A2AA-426EB7B74D70@roshambo.org>
To: Lars Strojny <lars@strojny.net>
In-Reply-To: <1211494158.7416.5.camel@localhost>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v919.2)
Date: Thu, 22 May 2008 17:10:54 -0700
References: <5B2E59A9-BC46-447F-BEBC-C4149866A802@roshambo.org> <1211494158.7416.5.camel@localhost>
Subject: Re: [PHP-DEV] magic quotes finale
From: philip@roshambo.org (Philip Olson)

>
>> PHP 5.3 is approaching fast, so let's conclude our dealings with
>> magical quotes... this should be the last time. Please have a look at
>> the following RFC and discuss it within this thread.
>>
>>   Magic Quotes in PHP 5.3 and beyond
>>   - http://wiki.php.net/rfc/magicquotes
>>
>> It recommends changes to both 5_3 and 6_0 branches, namely, removing
>> E_DEPRECATED from the get_ magical quote functions. Silence means
>> you're okay with the RFC being implemented.
>
> Why should we leave get_magic_quotes_gpc()? If someone wants to be
> backwards compatible, just use
> if (function_exists('get_magic_quotes_gpc') and  
> @get_magic_quotes_gpc())
> Let's just add this to the manual, and everything is fine.

We leave it because it's a developer friendly function that people  
use. The checking of this feature is not deprecated, but rather, the  
feature itself is deprecated and will be removed. And asking people to  
update past and present code because we don't want the string  
"magic_quotes" in php-src doesn't sound like much fun.

> I don't see a problem with this at all and it has the advantage of
> allowing use to remove all the traces of magic quotes in 6. Magic  
> quotes
> are considered a bad practice for a long time.

That's why good developers check for it, and why we shouldn't punish  
them for that. These E_* errors (and formally proposed removal  
outright) equal punishment. Also note that magic_quotes_gpc is enabled  
by default... even in PHP 5.3. So people have always checked for it,  
and will continue to do so, and we already have get_magic_quotes_*()  
so let's keep it with no E_rrors. Of course setting MQ is a totally  
different story.

> cu, Lars
> P.S.: Silence agrees doesn't work, silence is void.

In this case all silence would have done is temporarily move the  
conversation to php-cvs@.

Regards,
Philip