Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:37695 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5686 invoked from network); 17 May 2008 20:36:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 May 2008 20:36:37 -0000 Authentication-Results: pb1.pair.com header.from=hoffie@gentoo.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=hoffie@gentoo.org; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain gentoo.org does not designate 217.20.118.221 as permitted sender) X-PHP-List-Original-Sender: hoffie@gentoo.org X-Host-Fingerprint: 217.20.118.221 217.20.118.221 Received: from [217.20.118.221] ([217.20.118.221:41510] helo=srv.hoffie.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1B/6A-33811-0D14F284 for ; Sat, 17 May 2008 16:36:36 -0400 Received: from [192.168.1.2] (p5494D0B0.dip.t-dialin.net [84.148.208.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by srv.hoffie.info (Postfix) with ESMTP id 8BDA299D; Sat, 17 May 2008 22:36:29 +0200 (CEST) Message-ID: <482F41C8.7020703@gentoo.org> Date: Sat, 17 May 2008 22:36:24 +0200 User-Agent: Thunderbird 2.0.0.14 (X11/20080505) MIME-Version: 1.0 To: Lars Strojny CC: hirokawa@php.net, php-dev List References: <481D8C87.8020407@gentoo.org> <1210078046.6531.8.camel@localhost> In-Reply-To: <1210078046.6531.8.camel@localhost> X-Enigmail-Version: 0.95.6 OpenPGP: id=800DDCDE Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5E4B62277FFB6105CE1A7490" Subject: Re: [PHP-DEV] [PATCH] Allow for using external liboniguruma From: hoffie@gentoo.org (Christian Hoffmann) --------------enig5E4B62277FFB6105CE1A7490 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Hi, sorry for the late response, was really busy the last days. On 2008-05-06 14:47, Lars Strojny wrote: > Am Sonntag, den 04.05.2008, 12:14 +0200 schrieb Christian Hoffmann: > [...] >> as a distribution we usually aim at using system libraries instead of = >> bundled ones, both for security and maintainance reasons. >> PHP bundles liboniguruma (ext/mbstring/oniguruma) and currently does n= ot=20 >> allow for using an external copy of the lib. >> I hacked up a patch [1] which adds a new configure switch=20 >> (--with-onig-dir) and builds against the system lib accordingly. >> It would be nice if it could get included in the official sources.=20 >> Should be rather as easy as this patch should not (well, I tried, but = >> who knows) break backwards compatibility. >> Even if it won't get included, I guess it's still useful to post it he= re=20 >> so that other packagers can grab it as well. ;o) >=20 > Could you provide the patch for HEAD as well? I don't see a reason not > to include it. I ported the patch, but immediately noticed that while trying to test it:= $ ./configure --disable-all --enable-mbstring --disable-cgi --enable-cli = --with-pcre-regex=3Dyes checking whether to enable multibyte string support... yes checking whether to enable multibyte regex support... yes checking for external libmbfl... no configure: error: multibyte regex support must be disabled, use=20 --disable-mbregex Relevant code from ext/mbstring/config.m4: 275 if test "$PHP_MBREGEX" !=3D "no"; then 276 AC_MSG_ERROR([multibyte regex support must be disabled, use=20 --disable-mb regex]) Apparently mbregex is not supported in HEAD and as such there is no need = for oniguruma at all, is there? Maybe it was simply forgotten to re-enable it (apparently it was=20 disabled for