Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37649
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 64.233.182.189 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=kQov9CYjgoHy0bA7emwYAjhyx9qJuck7LyjsQtx7otIE6uPvmWUvW5WoEp69KsdPY1k6a3RSEHMEaBMHjLEPhUFr2wNUd7lZst+MYeRrjOjdukSvTdj7J+/8JAGbiBk4HXgk9A/T7i+YfOMFT+fzzR7vV8PyxtJ7heEnesiFnyw=
Message-ID: <10845a340805140705s6acd7c71rd49d0485c7cc520c@mail.gmail.com>
Date: Wed, 14 May 2008 15:05:20 +0100
Reply-To: RQuadling@GoogleMail.com
To: "Gregory Beaver" <greg@chiaraquartet.net>
Cc: "internals Mailing List" <internals@lists.php.net>
In-Reply-To: <482AED62.8050709@chiaraquartet.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4828BA83.7050900@chiaraquartet.net>
	 <48296276.4070103@daylessday.org>
	 <10845a340805140431u52942409p1d4896c96d8ddb66@mail.gmail.com>
	 <482AED62.8050709@chiaraquartet.net>
Subject: Re: [PHP-DEV] [HEADS UP] pecl/phar is now ext/phar
From: rquadling@googlemail.com ("Richard Quadling")

2008/5/14 Gregory Beaver <greg@chiaraquartet.net>:
> Richard Quadling wrote:
>> 2008/5/13 Antony Dovgal <tony@daylessday.org>:
>>
>>> On 13.05.2008 01:45, Gregory Beaver wrote:
>>>
>>>> Thanks to all who have contributed, particularly Marcus, Steph, Lars,
>>>> and the others who chimed in with ideas on the list.
>>>>
>>> phar_detect_phar_fname_ext() fails if is_complete = 1 and filename contains
>>> ".".
>>>
>>> For example:
>>> Breakpoint 1, phar_detect_phar_fname_ext (filename=0x124db80
>>> "/local/qa/5_3.zts/ext/phar/tests/DataArchive.phar", check_length=1,
>>>
>>
>>
>> Am I being picky in saying that having a . in a folder containing a
>> file should be allowed? And if there is an extension on the filename,
>> then it will also have a .
>>
> This was always the intention, and is already fixed.  In fact, opening
> URLs like phar://whatever/has.dot/my.phar/internal/file.php already
> worked, the only thing broken was instantiating a Phar object with a
> path containing "."
>> What happens for relative filenames?
>
> They have worked since phar 2.0.0a1.  The only requirement for phar to
> detect its file is that you either use a registered alias or that the
> filename contain a ".".  Executable phar archives must also contain
> ".phar" as part of the filename extension.
>
> In short, the problem with Phar objects crept in only because none of us
> had a path in our dev environment containing a "." and didn't think to
> add a test case for it until the problem appeared.  It's now fixed, and
> all tests pass in CVS.
>
> Greg
>

Thank you.

-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"