Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:37616 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7670 invoked from network); 13 May 2008 09:42:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 May 2008 09:42:32 -0000 Authentication-Results: pb1.pair.com header.from=tony@daylessday.org; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tony@daylessday.org; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain daylessday.org designates 89.208.40.236 as permitted sender) X-PHP-List-Original-Sender: tony@daylessday.org X-Host-Fingerprint: 89.208.40.236 mail.daylessday.org Linux 2.6 Received: from [89.208.40.236] ([89.208.40.236:42425] helo=daylessday.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DF/09-56987-58269284 for ; Tue, 13 May 2008 05:42:31 -0400 Received: from [192.168.3.91] (unknown [212.42.62.198]) by daylessday.org (Postfix) with ESMTP id 94AE5640100; Tue, 13 May 2008 13:42:25 +0400 (MSD) Message-ID: <48296276.4070103@daylessday.org> Date: Tue, 13 May 2008 13:42:14 +0400 User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Gregory Beaver CC: =?ISO-8859-1?Q?Johannes_Schl=FCter?= , internals Mailing List References: <4828BA83.7050900@chiaraquartet.net> In-Reply-To: <4828BA83.7050900@chiaraquartet.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [HEADS UP] pecl/phar is now ext/phar From: tony@daylessday.org (Antony Dovgal) On 13.05.2008 01:45, Gregory Beaver wrote: > Thanks to all who have contributed, particularly Marcus, Steph, Lars, > and the others who chimed in with ideas on the list. phar_detect_phar_fname_ext() fails if is_complete = 1 and filename contains ".". For example: Breakpoint 1, phar_detect_phar_fname_ext (filename=0x124db80 "/local/qa/5_3.zts/ext/phar/tests/DataArchive.phar", check_length=1, ext_str=0x7fff44a08fd8, ext_len=0x7fff44a08fcc, executable=1, for_create=0, is_complete=1, tsrm_ls=0xf5b0c0) at /local/qa/5_3.zts/ext/phar/phar.c:1557 1557 int filename_len = strlen(filename); (gdb) <..skip..> 1651 switch (phar_check_str(filename, *ext_str, *ext_len, executable, for_create TSRMLS_CC)) { (gdb) 1656 if (is_complete) { (gdb) 1657 return FAILURE; (gdb) p *ext_str $9 = 0x124db8d ".zts/ext/phar/tests/DataArchive.phar" This causes numerous test failures: Tests failed : 214 ( 56.8%) ( 58.8%) Tests passed : 150 ( 39.8%) ( 41.2%) -- Wbr, Antony Dovgal