Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37571
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain zend.com does not designate 64.97.136.171 as permitted sender)
Message-ID: <007801c8b291$456b2170$4001a8c0@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "internals" <internals@lists.php.net>
Cc: "Stanislav Malyshev" <stas@zend.com>
References: <021601c8b141$bbf64a50$4001a8c0@foxbox> <7f3ed2c30805081429q239a5d14k1d80e29cbd46acf6@mail.gmail.com> <00f801c8b1c5$942cd960$4001a8c0@foxbox>
Date: Sat, 10 May 2008 12:30:36 +0100
Organization: Zend Technologies
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] allow_call_time_pass_reference
From: steph@zend.com ("Steph Fox")

Folks,

>> I'd say throw the warning if the switch is on and someone does
>> call-time-pass-by-reference and turn that switch off by default.
>
> That's exactly the situation we have now - a warning when the INI setting 
> is changed, for code that by default runs silently.
>
> And we offer a recommendation to throw that warning in production. That's 
> the real WTF!
>
> If call-time pass-by-ref is something that needs to be warned about, warn 
> by default so everyone will get to see it during development. If it isn't 
> something that needs to be warned about, why throw a warning at all?

Did I hit the wrong season with this? Could someone with karma and history 
please respond?

On investigation, it seems allow_call_time_pass_reference shouldn't be 
E_DEPRECATED but E_STRICT, assuming it should throw a warning at all. It 
hasn't been removed in CVS HEAD, there are occasional genuine uses for it, 
and going by Stas' oblique message earlier in the week there may well be 
future genuine uses for it too, even if Derick mutters sth off-list about 
the spawn of Satan.

Off by default, off in php.ini-dist, possibly on in php.ini-recommended for 
BC reasons?

It's still the wrong way around.

- Steph