Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37546
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain zend.com does not designate 64.97.136.129 as permitted sender)
Message-ID: <021601c8b141$bbf64a50$4001a8c0@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "internals" <internals@lists.php.net>
Date: Thu, 8 May 2008 20:28:43 +0100
Organization: Zend Technologies
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_0213_01C8B14A.1C3E2470"
Subject: allow_call_time_pass_reference
From: steph@zend.com ("Steph Fox")

------=_NextPart_000_0213_01C8B14A.1C3E2470
Content-Type: text/plain;
	format=flowed;
	charset="utf-8";
	reply-type=original
Content-Transfer-Encoding: 7bit

Hi all,

Following a long and fairly embarrassing exchange of views with one of my 
php|architect authors, I finally discovered that 
allow_call_time_pass_reference is still on by default in PHP_5_3 (d'oh). 
This makes no sense to me because:

- it throws an E_DEPRECATED warning, which nobody will see during 
development because
- it's a PHP_INI_SYSTEM|PHP_INI_PERDIR setting that is switched on by 
default and
- on production sites, where it should be switched off, E_DEPRECATED is 
fairly likely to go unreported
- we've been advising people to switch it off for over 8 years

Does anyone have a good reason for keeping it switched on by default in PHP 
5.3? Like, would switching it off by default break a lot of existing code, 
given that most users are a bit beyond PHP 3 now?

If not, there's a trivial patch attached for main.c and both php.ini-* 
files.

As an aside, by-ref is actually faster than by-value under Windows in my 
tests, for small amounts of data. That was what you might call an unexpected 
result - it definitely isn't the case under *nix, or with very large arrays.

- Steph 

------=_NextPart_000_0213_01C8B14A.1C3E2470
Content-Type: text/plain;
	format=flowed;
	name="by-ref-ini.txt";
	reply-type=original
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="by-ref-ini.txt"

Index: php.ini-dist=0A=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
RCS file: /repository/php-src/php.ini-dist,v=0A=
retrieving revision 1.231.2.10.2.22.2.6=0A=
diff -u -r1.231.2.10.2.22.2.6 php.ini-dist=0A=
--- php.ini-dist	7 Apr 2008 21:24:04 -0000	1.231.2.10.2.22.2.6=0A=
+++ php.ini-dist	8 May 2008 18:45:44 -0000=0A=
@@ -164,12 +164,12 @@=0A=
 ; at function call time.  This method is deprecated and is likely to be=0A=
 ; unsupported in future versions of PHP/Zend.  The encouraged method of=0A=
 ; specifying which arguments should be passed by reference is in the =
function=0A=
-; declaration.  You're encouraged to try and turn this option Off and =
make=0A=
+; declaration.  You're encouraged to try and keep this option Off and =
make=0A=
 ; sure your scripts work properly with it in order to ensure they will =
work=0A=
 ; with future versions of the language (you will receive a warning each =
time=0A=
 ; you use this feature, and the argument will be passed by value =
instead of by=0A=
 ; reference).=0A=
-allow_call_time_pass_reference =3D On=0A=
+allow_call_time_pass_reference =3D Off=0A=
 =0A=
 ;=0A=
 ; Safe Mode=0A=
Index: php.ini-recommended=0A=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
RCS file: /repository/php-src/php.ini-recommended,v=0A=
retrieving revision 1.179.2.11.2.23.2.6=0A=
diff -u -r1.179.2.11.2.23.2.6 php.ini-recommended=0A=
--- php.ini-recommended	7 Apr 2008 21:24:04 -0000	1.179.2.11.2.23.2.6=0A=
+++ php.ini-recommended	8 May 2008 18:46:09 -0000=0A=
@@ -104,10 +104,6 @@=0A=
 ;     are emitted for non-critical errors, but that could be a symptom =
of a bigger=0A=
 ;     problem.  Most notably, this will cause error messages about the =
use=0A=
 ;     of uninitialized variables to be displayed.=0A=
-; - allow_call_time_pass_reference =3D Off     [Code cleanliness]=0A=
-;     It's not possible to decide to force a variable to be passed by =
reference=0A=
-;     when calling a function.  The PHP 4 style to do this is by making =
the=0A=
-;     function require the relevant argument by reference.=0A=
 ; - short_open_tag =3D Off           [Portability]=0A=
 ;     Using short tags is discouraged when developing code meant for =
redistribution=0A=
 ;     since short tags may not be supported on the target server.=0A=
@@ -213,7 +209,7 @@=0A=
 ; at function call time.  This method is deprecated and is likely to be=0A=
 ; unsupported in future versions of PHP/Zend.  The encouraged method of=0A=
 ; specifying which arguments should be passed by reference is in the =
function=0A=
-; declaration.  You're encouraged to try and turn this option Off and =
make=0A=
+; declaration.  You're encouraged to try and keep this option Off and =
make=0A=
 ; sure your scripts work properly with it in order to ensure they will =
work=0A=
 ; with future versions of the language (you will receive a warning each =
time=0A=
 ; you use this feature, and the argument will be passed by value =
instead of by=0A=
Index: main/main.c=0A=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
RCS file: /repository/php-src/main/main.c,v=0A=
retrieving revision 1.640.2.23.2.57.2.21=0A=
diff -u -r1.640.2.23.2.57.2.21 main.c=0A=
--- main/main.c	22 Mar 2008 12:56:16 -0000	1.640.2.23.2.57.2.21=0A=
+++ main/main.c	8 May 2008 18:46:21 -0000=0A=
@@ -370,7 +370,7 @@=0A=
 	PHP_INI_ENTRY_EX("highlight.keyword",		HL_KEYWORD_COLOR,	PHP_INI_ALL,	=
NULL,			php_ini_color_displayer_cb)=0A=
 	PHP_INI_ENTRY_EX("highlight.string",		HL_STRING_COLOR,	PHP_INI_ALL,	=
NULL,			php_ini_color_displayer_cb)=0A=
 =0A=
-	STD_PHP_INI_BOOLEAN("allow_call_time_pass_reference",	"1",	=
PHP_INI_SYSTEM|PHP_INI_PERDIR,		OnUpdateBool,	=
allow_call_time_pass_reference,	zend_compiler_globals,	compiler_globals)=0A=
+	STD_PHP_INI_BOOLEAN("allow_call_time_pass_reference",	"0",	=
PHP_INI_SYSTEM|PHP_INI_PERDIR,		OnUpdateBool,	=
allow_call_time_pass_reference,	zend_compiler_globals,	compiler_globals)=0A=
 	STD_PHP_INI_BOOLEAN("asp_tags",				"0",		=
PHP_INI_SYSTEM|PHP_INI_PERDIR,		OnUpdateBool,			asp_tags,				=
zend_compiler_globals,	compiler_globals)=0A=
 	STD_PHP_INI_ENTRY_EX("display_errors",		"1",		PHP_INI_ALL,		=
OnUpdateDisplayErrors,	display_errors,			php_core_globals,	core_globals, =
display_errors_mode)=0A=
 	STD_PHP_INI_BOOLEAN("display_startup_errors",	"0",	PHP_INI_ALL,		=
OnUpdateBool,			display_startup_errors,	php_core_globals,	core_globals)=0A=

------=_NextPart_000_0213_01C8B14A.1C3E2470--