Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37538
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.151.69.1 cause and error)
Message-ID: <015f01c8b0ee$e5114b40$0201a8c0@pc1>
To: "Steph Fox" <steph@zend.com>,
	"Rasmus Lerdorf" <rasmus@lerdorf.com>
Cc: "Hannes Magnusson" <hannes.magnusson@gmail.com>,
	<internals@lists.php.net>
References: <01a701c8b057$026a1890$0201a8c0@pc1> <7f3ed2c30805071316v5af796b2kd1fe338aa6e2d757@mail.gmail.com> <004901c8b0a4$98888cb0$4001a8c0@foxbox> <48224D58.3020700@lerdorf.com> <009701c8b0a6$05d87270$4001a8c0@foxbox>
Date: Thu, 8 May 2008 04:35:42 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Couple Windows build fixes
From: php_lists@realplain.com ("Matt Wilmas")

Hi all,

Thanks guys and gals!  (Steph, you're funny. ;o))  Yeah, I didn't get any
karma after my account was approved a few weeks ago, though I told Marcus
I'd been making random changes "all across the PHP source," so would need
access to php-src and ZendEngine2...  But I didn't expect that to just be
given right away, so I didn't want to bug anyone (more) about it.

Luckily my first two simple commits worked without wiping out the entire
history of PHP or anything. :-O  BTW, if I had karma for Zend stuff, I guess
I could fix Bugs #44681 and #44830, assuming my proposed fixes are
acceptable (should I have marked them Verified?).  And speaking of bugs, I
wasn't sure if I should close #44767 as Bogus, for example.  Maybe I will in
a few days unless I'm told not to. :-)


Thanks again,
Matt


----- Original Message -----
From: "Steph Fox"
Sent: Wednesday, May 07, 2008

> Then we'd better ask for him.
>
> Matt's been pushing patches all across the PHP source (if mostly at the
Zend
> Engine) for ages. He comes and goes, but pretty much all of his patches
were
> subsequently accepted. I don't recall off-hand which bits of the source he
> was given karma for a few weeks ago, but it's downright weird that it was
> ever limited.
>
>
> > He never asked.
> >
> > Steph Fox wrote:
> >> Hi Hannes,
> >>
> >> CVS HEAD wasn't updated yet with the Windows build system because I was
> >> waiting for re2c development to settle down first, given that there was
> >> no re2c binary available that PHP could be built with at all for
several
> >> weeks.
> >>
> >> But I agree with you, Matt should've been given access to everything
from
> >> Day One, we all know he's brilliant :)
> >>
> >> - Steph
> >>
> >> ----- Original Message ----- From: "Hannes Magnusson"
> >> <hannes.magnusson@gmail.com>
> >> To: "Matt Wilmas" <php_lists@realplain.com>
> >> Cc: <internals@lists.php.net>
> >> Sent: Wednesday, May 07, 2008 9:16 PM
> >> Subject: Re: [PHP-DEV] Couple Windows build fixes
> >>
> >>
> >>> Could someone explain to me why he doesn't have karma?
> >>>
> >>> -Hannes
> >>>
> >>> On Wed, May 7, 2008 at 5:28 PM, Matt Wilmas <php_lists@realplain.com>
> >>> wrote:
> >>>> Hi,
> >>>>
> >>>>  One patch for 5.3 and one for HEAD, where they're not synched with
the
> >>>>  other.  5.3's math changes the other day missed one change to the
> >>>> php_*
> >>>>  function (snaps are failing).  And HEAD's Win Makefile still
contains
> >>>>  references to flex.skl after the re2c change, which causes an error
> >>>> for me,
> >>>>  though its snaps are building, so maybe I'm the only one?
> >>>>
> >>>>
> >>>>  - Matt