Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37503
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.178.243 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding;
        b=vOdBoLmxP2OTRg2Ep6/m6Kv6dDWGbhkFmWP2bD/EIcUeNEiW9vgtsr6JWBb8KrUggcaAPf9cLp8gkXEakw7OSlpZJIvC+fyB8vtJ+zTm8opCS3uabqc6vHylJzYXmFZ+Bxsgentbw2SnUE3cxmOJmQDV6bETfTsT8wEBwdV+WHI=
To: Matt Wilmas <php_lists@realplain.com>
Cc: internals@lists.php.net
In-Reply-To: <01e801c8af82$3ed8bd20$0201a8c0@pc1>
References: <013a01c8aec5$b189d650$0201a8c0@pc1>
	 <481F8BCD.30207@lerdorf.com> <1210034790.5744.5.camel@pena>
	 <01e801c8af82$3ed8bd20$0201a8c0@pc1>
Content-Type: text/plain; charset=utf-8
Date: Tue, 06 May 2008 16:44:58 -0300
Message-ID: <1210103098.5344.17.camel@felipe>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] Some string changes/optimizations
From: felipensp@gmail.com (Felipe Pena)

Hi Matt, 
about optimization..., do you have any test for comparison? Why, in my
crazy test (http://rafb.net/p/ZzQQQP97.html), the actual code is more
faster than your patch.

real    0m1.156s
vs
real    0m1.368s

(using time command)


I'm just curious, i'm not against your patch.

Thanks.


Em Ter, 2008-05-06 às 09:05 -0500, Matt Wilmas escreveu:
> Hi Felipe, all,
> 
> The patches have been updated to fix the failing nowdoc_015.phpt test.
> 
> http://realplain.com/php/string_optimizations.diff
> http://realplain.com/php/string_optimizations_5_3.diff
> 
> The problem was that after removing the ST_START_NOWDOC stuff, the
> NOWDOC_CHARS pattern wasn't matching on:
> 
> <<<'EOT'
> SingleLineOfTextThatMatchesThe_LABEL_Pattern
> EOT;
> 
> I updated NOWDOC_CHARS, I think simplifying it a bit and making it more like
> HEREDOC_CHARS.  (And this made zend_language_scanner.c ~5K smaller.)  I
> previously tried to change it, and it just hung PHP when scanning a nowdoc
> (endless loop being generated somewhere, etc.), so I left it alone.  Looking
> into it more now, with the new pattern, re2c is messing up (endless loop)
> with
> 
> <ST_NOWDOC>{NOWDOC_CHARS}*{NEWLINE}+{LABEL}";"?[\n\r]
> 
> And I had to change it to
> 
> <ST_NOWDOC>({NOWDOC_CHARS}+{NEWLINE}+|{NEWLINE}+){LABEL}";"?[\n\r]
> 
> Though the original should be equivalent...  Well, hopefully it's all
> working correctly now!
> 
> 
> - Matt
> 
> 
> ----- Original Message -----
> From: "Felipe Pena"
> Sent: Monday, May 05, 2008
> 
> > [...]
> > Hi Matt, the nowdoc_015.phpt fails in HEAD.
> >
> > --
> > Regards,
> > Felipe Pena.
> >
> 
-- 
Regards,
Felipe Pena.