Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37497
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.151.69.1 cause and error)
Message-ID: <01e801c8af82$3ed8bd20$0201a8c0@pc1>
To: <internals@lists.php.net>,
	"Felipe Pena" <felipensp@gmail.com>
References: <013a01c8aec5$b189d650$0201a8c0@pc1> <481F8BCD.30207@lerdorf.com> <1210034790.5744.5.camel@pena>
Date: Tue, 6 May 2008 09:05:25 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Some string changes/optimizations
From: php_lists@realplain.com ("Matt Wilmas")

Hi Felipe, all,

The patches have been updated to fix the failing nowdoc_015.phpt test.

http://realplain.com/php/string_optimizations.diff
http://realplain.com/php/string_optimizations_5_3.diff

The problem was that after removing the ST_START_NOWDOC stuff, the
NOWDOC_CHARS pattern wasn't matching on:

<<<'EOT'
SingleLineOfTextThatMatchesThe_LABEL_Pattern
EOT;

I updated NOWDOC_CHARS, I think simplifying it a bit and making it more like
HEREDOC_CHARS.  (And this made zend_language_scanner.c ~5K smaller.)  I
previously tried to change it, and it just hung PHP when scanning a nowdoc
(endless loop being generated somewhere, etc.), so I left it alone.  Looking
into it more now, with the new pattern, re2c is messing up (endless loop)
with

<ST_NOWDOC>{NOWDOC_CHARS}*{NEWLINE}+{LABEL}";"?[\n\r]

And I had to change it to

<ST_NOWDOC>({NOWDOC_CHARS}+{NEWLINE}+|{NEWLINE}+){LABEL}";"?[\n\r]

Though the original should be equivalent...  Well, hopefully it's all
working correctly now!


- Matt


----- Original Message -----
From: "Felipe Pena"
Sent: Monday, May 05, 2008

> [...]
> Hi Matt, the nowdoc_015.phpt fails in HEAD.
>
> --
> Regards,
> Felipe Pena.
>