Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:37491 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33478 invoked from network); 6 May 2008 00:46:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 May 2008 00:46:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=felipensp@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=felipensp@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.166.181 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: felipensp@gmail.com X-Host-Fingerprint: 64.233.166.181 py-out-1112.google.com Received: from [64.233.166.181] ([64.233.166.181:45030] helo=py-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FB/04-03684-07AAF184 for ; Mon, 05 May 2008 20:46:40 -0400 Received: by py-out-1112.google.com with SMTP id u77so962320pyb.16 for ; Mon, 05 May 2008 17:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=9rp+KcjBpNDNh5MrV6dbsQsf5VeVjhZKbdHR1JtB6zQ=; b=Fax9hr6FqOLEog0jkMhAAdCNRazD5IzMxGPWtCbZS/ExcehkR9BJ4mWB9772mhqaZOrNc5wVpBBij5gXJct4+8qToLnylCrIB17jHLc6iXr8e4N7LuVJTaVFRZWmafzcYlYPA2leliI5ieeQxrC5r9Kq4MuXlBrHH/UulfeJzVg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=xOiYao3qBH571e2Nu9ug4daxDLnEhUJRPIZtCoA8SOA330gDCOLp1Xb+OvK+jcuzWbRA6Rwht4zVpie8ZVrDmVsDlQOX1Es2nkuhkwes4M48ZynI4pvkiTLkhQ4RK4R8krsp6gWwtk6Amrr9fnbK5IndJVchVnKWNU69KXtxnGE= Received: by 10.65.54.9 with SMTP id g9mr238919qbk.80.1210034796101; Mon, 05 May 2008 17:46:36 -0700 (PDT) Received: from ?189.24.45.172? ( [189.24.45.172]) by mx.google.com with ESMTPS id q18sm26471qbq.22.2008.05.05.17.46.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 05 May 2008 17:46:35 -0700 (PDT) To: Rasmus Lerdorf Cc: Matt Wilmas , internals@lists.php.net In-Reply-To: <481F8BCD.30207@lerdorf.com> References: <013a01c8aec5$b189d650$0201a8c0@pc1> <481F8BCD.30207@lerdorf.com> Content-Type: text/plain Date: Mon, 05 May 2008 21:46:30 -0300 Message-ID: <1210034790.5744.5.camel@pena> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Some string changes/optimizations From: felipensp@gmail.com (Felipe Pena) > Fatal error: Invalid opcode 56/16/8. in > /Users/rasmus/php53/run-tests.php on line 547 > > Could we get a cleaner patch to have a look at? One that doesn't hurt > my brain quite as much to get working? > Because he doesn't attached the regenerated zend_vm_execute.h in the patch. > Matt Wilmas wrote: > > Hi all, > > > > This patch... Saves one opcode per interpolated string by moving what was > > the first ADD_STRING/ADD_VAR op into INIT_STRING; changes the > > ADD_[CHAR|STRING|VAR] op types from (TMP, ) to (, > > UNUSED), since that seems to make more sense (see ADD_ARRAY_ELEMENT) and > > simplifies things a bit, and saves some znode copying while compiling. > > > > http://realplain.com/php/string_optimizations.diff > > http://realplain.com/php/string_optimizations_5_3.diff > > Hi Matt, the nowdoc_015.phpt fails in HEAD. -- Regards, Felipe Pena.