Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:37469
Return-Path: <nlopess@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 57505 invoked from network); 5 May 2008 17:39:10 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 May 2008 17:39:10 -0000
Authentication-Results: pb1.pair.com header.from=nlopess@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=nlopess@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 212.55.154.26 as permitted sender)
X-PHP-List-Original-Sender: nlopess@php.net
X-Host-Fingerprint: 212.55.154.26 relay6.ptmail.sapo.pt Linux 2.4/2.6
Received: from [212.55.154.26] ([212.55.154.26:34423] helo=sapo.pt)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id E5/0D-14293-C364F184 for <internals@lists.php.net>; Mon, 05 May 2008 13:39:09 -0400
Received: (qmail 8416 invoked from network); 5 May 2008 17:39:03 -0000
Received: from unknown (HELO sapo.pt) (10.134.35.209)
  by relay6 with SMTP; 5 May 2008 17:39:03 -0000
Received: (qmail 28746 invoked from network); 5 May 2008 17:38:59 -0000
X-AntiVirus: PTMail-AV 0.3-0.92.0
X-Virus-Status: Clean (0.00611 seconds)
Received: from unknown (HELO pc07654) (nunoplopes@sapo.pt@[85.243.104.254])
          (envelope-sender <nlopess@php.net>)
          by mta14 (qmail-ldap-1.03) with SMTP
          for <php_lists@realplain.com>; 5 May 2008 17:38:59 -0000
Message-ID: <3ABDA0E2FE7748F1A6C133782E6E520F@pc07654>
To: "Matt Wilmas" <php_lists@realplain.com>,
	<internals@lists.php.net>
Cc: <helly@php.net>
References: <013a01c8aec5$b189d650$0201a8c0@pc1>
In-Reply-To: <013a01c8aec5$b189d650$0201a8c0@pc1>
Date: Mon, 5 May 2008 18:38:50 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Windows Mail 6.0.6001.18000
X-MimeOLE: Produced By Microsoft MimeOLE V6.0.6001.18000
Subject: Re: [PHP-DEV] [PATCH] Some string changes/optimizations
From: nlopess@php.net ("Nuno Lopes")

Thanks Matt for the nice work :)

> Also removed the ST_START_[HEREDOC|NOWDOC] states
> in the scanner, by doing their work (to catch immediate ending label) in 
> the
> initial heredoc rule.

This one was in my todo list as well. I think there might be other places 
where a similar optimization can be done.


> Oh, almost forgot a couple things -- for HEAD: updated the yyless()
> definition to match 5_3 (Nuno didn't get to it yet...), and moved
(...)
> P.S. (for Marcus?), the ({LABEL}|([']{LABEL}['])|(["]{LABEL}["])) part of
> the heredoc rule crashed re2c (Windows) until I added the extra ( ), which
> shouldn't be needed AFAIK and was fine with just 2 alternate matches...

Thanks. I didn't commit the yyless() merge yet because it was crashing re2c. 
I found it to be related with 2 different bugs in re2c. I've fixed one, but 
the other is still there. Maybe I should pass the details to Marcus, as I 
don't have time to fix it myself until the end of the month.

Nuno