Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:37466 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67155 invoked from network); 5 May 2008 13:31:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 May 2008 13:31:24 -0000 Authentication-Results: pb1.pair.com header.from=xuefer@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=xuefer@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.146.180 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: xuefer@gmail.com X-Host-Fingerprint: 209.85.146.180 wa-out-1112.google.com Received: from [209.85.146.180] ([209.85.146.180:12076] helo=wa-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3A/2B-14293-B2C0F184 for ; Mon, 05 May 2008 09:31:23 -0400 Received: by wa-out-1112.google.com with SMTP id v27so953144wah.17 for ; Mon, 05 May 2008 06:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; bh=OR8AAoC3aORpV5odsjBD/XHVefXXlM7c+zRURbNFRfk=; b=ijaJVWwfX98d1s78emE+b2BrAnmlIHl4ietkzdIoQGmmDbSPBYDNAdG4ihGLnGR+Qea52ADhek7wedwvPXg8NxWdcGjafsOcGI8GvgQ23cj3pdodW/kZiCyJUdC5JQkTwwdXuryqHSxCQvgBfJgiDOZtDYBV1xIbyf5qQys9LXU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=NM0/FVf4ZuHJqoSUFIM4l0oHHkeCGsJ6jaWhB0F7jNVPlvhKj3OlA7AD200X640O523yJEV4lMDxs3FZUVfR8Kr6GNzdMCcBV3mcZoeIxyjNut+9yjsk37DDqQp/KVm2ob4EMZNlcm6Cb5+GyhVQbTzw/N4zItfnmPK0biZK03w= Received: by 10.114.184.7 with SMTP id h7mr5684884waf.28.1209994281040; Mon, 05 May 2008 06:31:21 -0700 (PDT) Received: by 10.115.33.6 with HTTP; Mon, 5 May 2008 06:31:21 -0700 (PDT) Message-ID: <28139bc0805050631s32760a73ya446e58e48b2464a@mail.gmail.com> Date: Mon, 5 May 2008 21:31:21 +0800 To: "internals Mailing List" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: simplify code for ext/date/config.{m4,w32} From: xuefer@gmail.com (Xuefer) in ext/date/ of php5/6, i see the following code ===config.m4===== cat > $ext_builddir/lib/timelib_config.h < #endif EOF ===config.w32===== var tl_config = FSO.CreateTextFile("ext/date/lib/timelib_config.h", true); tl_config.WriteLine("#include \"config.w32.h\""); tl_config.Close(); ================ if #ifdef PHP_WIN32 works, why do we bother generate? just add a timelib_config.h in cvs